happyz
/
memos
mirror of https://github.com/usememos/memos.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix(lint): correct goimports struct literal alignment after removing write-only credential fields 

When credential fields (ClientSecret, AccessKeySecret) were replaced with
write-only comments in commit 9d3a74b, the remaining struct literal fields
were not re-aligned to match goimports expected column alignment.

- idp_service.go: align AuthUrl/TokenUrl/UserInfoUrl/Scopes at col 14
  (longest field FieldMapping = 12 chars in post-comment group)
- instance_service.go: align AccessKeyId alone at col 13, and
  Endpoint/Region/Bucket at col 14 to match UsePathStyle (longest in
  post-comment group)

https://claude.ai/code/session_01DVhwUL8RG8HVrcChv5qHdh
This commit is contained in:
Claude 2026-03-29 05:52:47 +00:00
parent 9d3a74bccc
commit 21a5f541c9
No known key found for this signature in database
2 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
server/router/api/v1/idp_service.go
View File

@ -182,10 +182,10 @@ func convertIdentityProviderFromStore(identityProvider *storepb.IdentityProvider
Oauth2Config: &v1pb.OAuth2Config{
ClientId: oauth2Config.ClientId,
// ClientSecret is write-only: never returned in responses.
AuthUrl: oauth2Config.AuthUrl,
TokenUrl: oauth2Config.TokenUrl,
UserInfoUrl: oauth2Config.UserInfoUrl,
Scopes: oauth2Config.Scopes,
AuthUrl: oauth2Config.AuthUrl,
TokenUrl: oauth2Config.TokenUrl,
UserInfoUrl: oauth2Config.UserInfoUrl,
Scopes: oauth2Config.Scopes,
FieldMapping: &v1pb.FieldMapping{
Identifier: oauth2Config.FieldMapping.Identifier,
DisplayName: oauth2Config.FieldMapping.DisplayName,

8
server/router/api/v1/instance_service.go
View File

@ -261,11 +261,11 @@ func convertInstanceStorageSettingFromStore(settingpb *storepb.InstanceStorageSe
}
if settingpb.S3Config != nil {
setting.S3Config = &v1pb.InstanceSetting_StorageSetting_S3Config{
AccessKeyId: settingpb.S3Config.AccessKeyId,
AccessKeyId: settingpb.S3Config.AccessKeyId,
// AccessKeySecret is write-only: never returned in responses.
Endpoint: settingpb.S3Config.Endpoint,
Region: settingpb.S3Config.Region,
Bucket: settingpb.S3Config.Bucket,
Endpoint: settingpb.S3Config.Endpoint,
Region: settingpb.S3Config.Region,
Bucket: settingpb.S3Config.Bucket,
UsePathStyle: settingpb.S3Config.UsePathStyle,
}
}