From 21a5f541c93e335763b6963f02df9e2ad0668fd1 Mon Sep 17 00:00:00 2001 From: Claude Date: Sun, 29 Mar 2026 05:52:47 +0000 Subject: [PATCH] fix(lint): correct goimports struct literal alignment after removing write-only credential fields When credential fields (ClientSecret, AccessKeySecret) were replaced with write-only comments in commit 9d3a74b, the remaining struct literal fields were not re-aligned to match goimports expected column alignment. - idp_service.go: align AuthUrl/TokenUrl/UserInfoUrl/Scopes at col 14 (longest field FieldMapping = 12 chars in post-comment group) - instance_service.go: align AccessKeyId alone at col 13, and Endpoint/Region/Bucket at col 14 to match UsePathStyle (longest in post-comment group) https://claude.ai/code/session_01DVhwUL8RG8HVrcChv5qHdh --- server/router/api/v1/idp_service.go | 8 ++++---- server/router/api/v1/instance_service.go | 8 ++++---- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/server/router/api/v1/idp_service.go b/server/router/api/v1/idp_service.go index 52535733e..bad74f31c 100644 --- a/server/router/api/v1/idp_service.go +++ b/server/router/api/v1/idp_service.go @@ -182,10 +182,10 @@ func convertIdentityProviderFromStore(identityProvider *storepb.IdentityProvider Oauth2Config: &v1pb.OAuth2Config{ ClientId: oauth2Config.ClientId, // ClientSecret is write-only: never returned in responses. - AuthUrl: oauth2Config.AuthUrl, - TokenUrl: oauth2Config.TokenUrl, - UserInfoUrl: oauth2Config.UserInfoUrl, - Scopes: oauth2Config.Scopes, + AuthUrl: oauth2Config.AuthUrl, + TokenUrl: oauth2Config.TokenUrl, + UserInfoUrl: oauth2Config.UserInfoUrl, + Scopes: oauth2Config.Scopes, FieldMapping: &v1pb.FieldMapping{ Identifier: oauth2Config.FieldMapping.Identifier, DisplayName: oauth2Config.FieldMapping.DisplayName, diff --git a/server/router/api/v1/instance_service.go b/server/router/api/v1/instance_service.go index 76166a5ba..127bdd94b 100644 --- a/server/router/api/v1/instance_service.go +++ b/server/router/api/v1/instance_service.go @@ -261,11 +261,11 @@ func convertInstanceStorageSettingFromStore(settingpb *storepb.InstanceStorageSe } if settingpb.S3Config != nil { setting.S3Config = &v1pb.InstanceSetting_StorageSetting_S3Config{ - AccessKeyId: settingpb.S3Config.AccessKeyId, + AccessKeyId: settingpb.S3Config.AccessKeyId, // AccessKeySecret is write-only: never returned in responses. - Endpoint: settingpb.S3Config.Endpoint, - Region: settingpb.S3Config.Region, - Bucket: settingpb.S3Config.Bucket, + Endpoint: settingpb.S3Config.Endpoint, + Region: settingpb.S3Config.Region, + Bucket: settingpb.S3Config.Bucket, UsePathStyle: settingpb.S3Config.UsePathStyle, } }