happyz
/
llama.cpp
mirror of https://github.com/ggerganov/llama.cpp.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

nit: minor UI patch; add missing comments

This commit is contained in:
Han Yin 2025-07-08 13:06:16 -07:00
parent 6f901e5203
commit 5b7619f000
3 changed files with 8 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
examples/llama.android/app/src/main/java/com/example/llama/ui/screens/ModelSelectionScreen.kt
View File

@ -126,7 +126,7 @@ fun ModelSelectionScreen(
) { ) {
if (queryResults.isEmpty()) { if (queryResults.isEmpty()) {
if (searchQuery.isNotBlank()) { if (searchQuery.isNotBlank()) {
// Show "no results" message // If no results under current query, show "no results" message
EmptySearchResultsView( EmptySearchResultsView(
onClearSearch = { onClearSearch = {
textFieldState.clearText() textFieldState.clearText()
@ -136,7 +136,7 @@ fun ModelSelectionScreen(
} }
} else { } else {
LazyColumn( LazyColumn(
Modifier.fillMaxSize(), modifier = Modifier.fillMaxSize(),
verticalArrangement = Arrangement.spacedBy(12.dp), verticalArrangement = Arrangement.spacedBy(12.dp),
contentPadding = PaddingValues(vertical = 12.dp, horizontal = 16.dp), contentPadding = PaddingValues(vertical = 12.dp, horizontal = 16.dp),
) { ) {
@ -164,8 +164,10 @@ fun ModelSelectionScreen(
} }
} else { } else {
if (filteredModels.isEmpty()) { if (filteredModels.isEmpty()) {
// Empty model prompt
EmptyModelsView(activeFiltersCount, onManageModelsClicked) EmptyModelsView(activeFiltersCount, onManageModelsClicked)
} else { } else {
// Model cards
LazyColumn( LazyColumn(
Modifier.fillMaxSize(), // .padding(horizontal = 16.dp), Modifier.fillMaxSize(), // .padding(horizontal = 16.dp),
verticalArrangement = Arrangement.spacedBy(12.dp), verticalArrangement = Arrangement.spacedBy(12.dp),

6
examples/llama.android/app/src/main/java/com/example/llama/ui/screens/ModelsManagementScreen.kt
View File

@ -108,6 +108,7 @@ fun ModelsManagementScreen(
Box(modifier = Modifier.fillMaxSize()) { Box(modifier = Modifier.fillMaxSize()) {
if (filteredModels.isEmpty()) { if (filteredModels.isEmpty()) {
// Import model prompt
val message = when (activeFiltersCount) { val message = when (activeFiltersCount) {
0 -> "Tap the \"+\" button to import a model!" 0 -> "Tap the \"+\" button to import a model!"
1 -> "No models match the selected filter" 1 -> "No models match the selected filter"
@ -121,10 +122,9 @@ fun ModelsManagementScreen(
} else { } else {
// Model cards // Model cards
LazyColumn( LazyColumn(
modifier = Modifier modifier = Modifier.fillMaxSize(),
.fillMaxSize()
.padding(horizontal = 16.dp),
verticalArrangement = Arrangement.spacedBy(12.dp), verticalArrangement = Arrangement.spacedBy(12.dp),
contentPadding = PaddingValues(vertical = 12.dp, horizontal = 16.dp),
) { ) {
items(items = filteredModels, key = { it.id }) { model -> items(items = filteredModels, key = { it.id }) { model ->
val isSelected = val isSelected =

2
examples/llama.android/app/src/main/java/com/example/llama/viewmodel/ConversationViewModel.kt
View File

@ -43,7 +43,7 @@ class ConversationViewModel @Inject constructor(
// UI state: Input text field // UI state: Input text field
val inputFieldState = TextFieldState() val inputFieldState = TextFieldState()
// Token generation job // Ongoing coroutine jobs
private var tokenCollectionJob: Job? = null private var tokenCollectionJob: Job? = null
/** /**