From 5b7619f0006a62581d34646fe2ffbfd91c70a60e Mon Sep 17 00:00:00 2001
From: Han Yin <han.yin@arm.com>
Date: Tue, 8 Jul 2025 13:06:16 -0700
Subject: [PATCH] nit: minor UI patch; add missing comments

---
 .../com/example/llama/ui/screens/ModelSelectionScreen.kt    | 6 ++++--
 .../com/example/llama/ui/screens/ModelsManagementScreen.kt  | 6 +++---
 .../com/example/llama/viewmodel/ConversationViewModel.kt    | 2 +-
 3 files changed, 8 insertions(+), 6 deletions(-)

diff --git a/examples/llama.android/app/src/main/java/com/example/llama/ui/screens/ModelSelectionScreen.kt b/examples/llama.android/app/src/main/java/com/example/llama/ui/screens/ModelSelectionScreen.kt
index 640b136bee..6f03fa1954 100644
--- a/examples/llama.android/app/src/main/java/com/example/llama/ui/screens/ModelSelectionScreen.kt
+++ b/examples/llama.android/app/src/main/java/com/example/llama/ui/screens/ModelSelectionScreen.kt
@@ -126,7 +126,7 @@ fun ModelSelectionScreen(
             ) {
                 if (queryResults.isEmpty()) {
                     if (searchQuery.isNotBlank()) {
-                        // Show "no results" message
+                        // If no results under current query, show "no results" message
                         EmptySearchResultsView(
                             onClearSearch = {
                                 textFieldState.clearText()
@@ -136,7 +136,7 @@ fun ModelSelectionScreen(
                     }
                 } else {
                     LazyColumn(
-                        Modifier.fillMaxSize(),
+                        modifier = Modifier.fillMaxSize(),
                         verticalArrangement = Arrangement.spacedBy(12.dp),
                         contentPadding = PaddingValues(vertical = 12.dp, horizontal = 16.dp),
                     ) {
@@ -164,8 +164,10 @@ fun ModelSelectionScreen(
             }
         } else {
             if (filteredModels.isEmpty()) {
+                // Empty model prompt
                 EmptyModelsView(activeFiltersCount, onManageModelsClicked)
             } else {
+                // Model cards
                 LazyColumn(
                     Modifier.fillMaxSize(), // .padding(horizontal = 16.dp),
                     verticalArrangement = Arrangement.spacedBy(12.dp),
diff --git a/examples/llama.android/app/src/main/java/com/example/llama/ui/screens/ModelsManagementScreen.kt b/examples/llama.android/app/src/main/java/com/example/llama/ui/screens/ModelsManagementScreen.kt
index 1c74787bcd..d8017c57b6 100644
--- a/examples/llama.android/app/src/main/java/com/example/llama/ui/screens/ModelsManagementScreen.kt
+++ b/examples/llama.android/app/src/main/java/com/example/llama/ui/screens/ModelsManagementScreen.kt
@@ -108,6 +108,7 @@ fun ModelsManagementScreen(
 
     Box(modifier = Modifier.fillMaxSize()) {
         if (filteredModels.isEmpty()) {
+            // Import model prompt
             val message = when (activeFiltersCount) {
                 0 -> "Tap the \"+\" button to import a model!"
                 1 -> "No models match the selected filter"
@@ -121,10 +122,9 @@ fun ModelsManagementScreen(
         } else {
             // Model cards
             LazyColumn(
-                modifier = Modifier
-                    .fillMaxSize()
-                    .padding(horizontal = 16.dp),
+                modifier = Modifier.fillMaxSize(),
                 verticalArrangement = Arrangement.spacedBy(12.dp),
+                contentPadding = PaddingValues(vertical = 12.dp, horizontal = 16.dp),
             ) {
                 items(items = filteredModels, key = { it.id }) { model ->
                     val isSelected =
diff --git a/examples/llama.android/app/src/main/java/com/example/llama/viewmodel/ConversationViewModel.kt b/examples/llama.android/app/src/main/java/com/example/llama/viewmodel/ConversationViewModel.kt
index 72c12b1375..e19c55ddba 100644
--- a/examples/llama.android/app/src/main/java/com/example/llama/viewmodel/ConversationViewModel.kt
+++ b/examples/llama.android/app/src/main/java/com/example/llama/viewmodel/ConversationViewModel.kt
@@ -43,7 +43,7 @@ class ConversationViewModel @Inject constructor(
     // UI state: Input text field
     val inputFieldState = TextFieldState()
 
-    // Token generation job
+    // Ongoing coroutine jobs
     private var tokenCollectionJob: Job? = null
 
     /**