Merge branch 'merge_to_jackimonster' into 'main'

Merge device changes from https://github.com/wheaney/xrealAirLinuxDriver

See merge request TheJackiMonster/nrealAirLinuxDriver!2

CMakeLists.txt

@@ -11,9 +11,9 @@ add_executable(nrealAirLinuxDriver
 )
 
 target_include_directories(nrealAirLinuxDriver
-		BEFORE PUBLIC ${NRA_INCLUDE_DIR}
+		BEFORE PUBLIC ${NREAL_AIR_INCLUDE_DIR}
 )
 
 target_link_libraries(nrealAirLinuxDriver
-		${NRA_LIBRARY}
+		${NREAL_AIR_LIBRARY}
 )

examples/debug_d3/CMakeLists.txt

@@ -9,9 +9,9 @@ add_executable(
 )
 
 target_include_directories(nrealAirDebugD3
-		BEFORE PUBLIC ${NRA_INCLUDE_DIR}
+		BEFORE PUBLIC ${NREAL_AIR_INCLUDE_DIR}
 )
 
 target_link_libraries(nrealAirDebugD3
-		${NRA_LIBRARY}
+		${NREAL_AIR_LIBRARY}
 )

examples/debug_d4/CMakeLists.txt

@@ -9,9 +9,9 @@ add_executable(
 )
 
 target_include_directories(nrealAirDebugD4
-		BEFORE PUBLIC ${NRA_INCLUDE_DIR}
+		BEFORE PUBLIC ${NREAL_AIR_INCLUDE_DIR}
 )
 
 target_link_libraries(nrealAirDebugD4
-		${NRA_LIBRARY}
+		${NREAL_AIR_LIBRARY}
 )

examples/mcu_firmware/CMakeLists.txt

@@ -9,9 +9,9 @@ add_executable(
 )
 
 target_include_directories(nrealAirUpgradeMCU
-		BEFORE PUBLIC ${NRA_INCLUDE_DIR}
+		BEFORE PUBLIC ${NREAL_AIR_INCLUDE_DIR}
 )
 
 target_link_libraries(nrealAirUpgradeMCU
-		${NRA_LIBRARY}
+		${NREAL_AIR_LIBRARY}
 )

interface_lib/CMakeLists.txt

@@ -15,6 +15,8 @@ add_library(
 		src/device4.c
 )
 
+target_compile_options(nrealAirLibrary PRIVATE -fPIC)
+
 target_include_directories(nrealAirLibrary
 		BEFORE PUBLIC include
 )
@@ -26,8 +28,8 @@ target_include_directories(nrealAirLibrary
 )
 
 target_link_libraries(nrealAirLibrary
-		hidapi::hidapi json-c::json-c Fusion m
+		PRIVATE hidapi::hidapi json-c::json-c Fusion m
 )
 
-set(NRA_INCLUDE_DIR ${CMAKE_CURRENT_SOURCE_DIR}/include PARENT_SCOPE)
-set(NRA_LIBRARY nrealAirLibrary PARENT_SCOPE)
+set(NREAL_AIR_INCLUDE_DIR ${CMAKE_CURRENT_SOURCE_DIR}/include PARENT_SCOPE)
+set(NREAL_AIR_LIBRARY nrealAirLibrary PARENT_SCOPE)

interface_lib/src/device3.c

@@ -617,9 +617,14 @@ int device3_calibrate(device3_type* device, uint32_t iterations, bool gyro, bool
 		return -1;
 	}
 
+	if (!device->handle) {
+		device3_error("No handle");
+		return -2;
+	}
+	
 	if (MAX_PACKET_SIZE != sizeof(device3_packet_type)) {
 		device3_error("Not proper size");
-		return -2;
+		return -3;
 	}
 	
 	device3_packet_type packet;
@@ -642,13 +647,18 @@ int device3_calibrate(device3_type* device, uint32_t iterations, bool gyro, bool
 			MAX_PACKET_SIZE
 		);
 
+		if (transferred == -1) {
+			device3_error("Device may be unplugged");
+			return -4;
+		}
+
 		if (transferred == 0) {
 			continue;
 		}
 
 		if (MAX_PACKET_SIZE != transferred) {
 			device3_error("Not expected issue");
-			return -3;
+			return -5;
 		}
 		
 		if ((packet.signature[0] != 0x01) || (packet.signature[1] != 0x02)) {
@@ -748,13 +758,18 @@ int device3_read(device3_type* device, int timeout) {
 		timeout
 	);
 
+	if (transferred == -1) {
+		device3_error("Device may be unplugged");
+		return -4;
+	}
+	
 	if (transferred == 0) {
 		return 1;
 	}
 	
 	if (MAX_PACKET_SIZE != transferred) {
-		device3_error("Not expected issue");
-		return -4;
+		device3_error("Unexpected packet size");
+		return -5;
 	}
 	
 	const uint64_t timestamp = packet.timestamp;
@@ -766,7 +781,7 @@ int device3_read(device3_type* device, int timeout) {
 	
 	if ((packet.signature[0] != 0x01) || (packet.signature[1] != 0x02)) {
 		device3_error("Not matching signature");
-		return -5;
+		return -6;
 	}
 	
 	const uint64_t delta = timestamp - device->last_timestamp;
@@ -795,8 +810,18 @@ int device3_read(device3_type* device, int timeout) {
 	//printf("M: %.2f %.2f %.2f\n", magnetometer.axis.x, magnetometer.axis.y, magnetometer.axis.z);
 	
 	if (device->ahrs) {
-		FusionAhrsUpdate((FusionAhrs*) device->ahrs, gyroscope, accelerometer, magnetometer, deltaTime);
-		//FusionAhrsUpdateNoMagnetometer((FusionAhrs*) device->ahrs, gyroscope, accelerometer, deltaTime);
+		/* The magnetometer seems to make results of sensor fusion generally worse. So it is not used currently. */
+		//FusionAhrsUpdate((FusionAhrs*) device->ahrs, gyroscope, accelerometer, magnetometer, deltaTime);
+		FusionAhrsUpdateNoMagnetometer((FusionAhrs*) device->ahrs, gyroscope, accelerometer, deltaTime);
+
+		const device3_quat_type orientation = device3_get_orientation(device->ahrs);
+
+		// TODO: fix detection of this case; quat.x as a nan value is only a side-effect of some issue with ahrs or
+		//       the gyro/accel/magnet readings
+		if (isnan(orientation.x) || isnan(orientation.y) || isnan(orientation.z) || isnan(orientation.w)) {
+			device3_error("Invalid orientation reading");
+			return -7;
+		}
 	}
 	
 	device3_callback(device, timestamp, DEVICE3_EVENT_UPDATE);