happyz
/
memos
mirror of https://github.com/usememos/memos.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
memos/store/test
History
Johnny db57f4456a fix: resolve data races in store tests with atomic operations 
Fix all data races detected by -race flag in parallel store tests.

Problems fixed:
1. TestMain not propagating exit code
   - Was: m.Run(); return
   - Now: os.Exit(m.Run())

2. Data races on global DSN variables
   - mysqlBaseDSN and postgresBaseDSN written in sync.Once
   - Read outside Once without synchronization
   - Race detector: write/read without happens-before relationship

3. Data races on container pointers
   - mysqlContainer, postgresContainer, testDockerNetwork
   - Same pattern: write in Once, read in cleanup

Solution: Use atomic operations
- atomic.Value for DSN strings (Store/Load)
- atomic.Pointer for container pointers (Store/Load)
- Provides proper memory synchronization
- Race-free reads and writes

Why sync.Once alone wasn't enough:
- sync.Once guarantees function runs once
- Does NOT provide memory barrier for variables written inside
- Reads outside Once have no synchronization with writes
- Race detector correctly flags this as violation

Technical details:
- atomic.Value.Store() provides release semantics
- atomic.Value.Load() provides acquire semantics
- Guarantees happens-before relationship per Go memory model
- All 159 parallel tests can safely access globals

Impact:
- Tests now pass with -race flag
- No performance degradation (atomic ops are fast)
- Maintains parallel execution benefits (8-10x speedup)
- Proper Go memory model compliance

Related: Issues #2, #3 from race analysis
 		2026-01-14 23:37:12 +08:00
..
Dockerfile test: improve migration tests stability and maintainability 2026-01-07 23:04:12 +08:00
README.md chore: move store test 2025-03-17 21:51:02 +08:00
activity_test.go perf: enable parallel execution for all store tests 2026-01-14 22:44:19 +08:00
attachment_filter_test.go perf: enable parallel execution for all store tests 2026-01-14 22:44:19 +08:00
attachment_test.go perf: enable parallel execution for all store tests 2026-01-14 22:44:19 +08:00
containers.go fix: resolve data races in store tests with atomic operations 2026-01-14 23:37:12 +08:00
filter_helpers_test.go chore: add store tests (#5397) 2025-12-31 21:26:35 +08:00
idp_test.go perf: enable parallel execution for all store tests 2026-01-14 22:44:19 +08:00
inbox_test.go perf: enable parallel execution for all store tests 2026-01-14 22:44:19 +08:00
instance_setting_test.go perf: enable parallel execution for all store tests 2026-01-14 22:44:19 +08:00
main_test.go fix: resolve data races in store tests with atomic operations 2026-01-14 23:37:12 +08:00
memo_filter_test.go perf: enable parallel execution for all store tests 2026-01-14 22:44:19 +08:00
memo_relation_test.go perf: enable parallel execution for all store tests 2026-01-14 22:44:19 +08:00
memo_test.go perf: enable parallel execution for all store tests 2026-01-14 22:44:19 +08:00
migrator_test.go perf: enable parallel execution for all store tests 2026-01-14 22:44:19 +08:00
reaction_test.go perf: enable parallel execution for all store tests 2026-01-14 22:44:19 +08:00
store.go chore: add store tests (#5397) 2025-12-31 21:26:35 +08:00
user_setting_test.go perf: enable parallel execution for all store tests 2026-01-14 22:44:19 +08:00
user_test.go perf: enable parallel execution for all store tests 2026-01-14 22:44:19 +08:00

README.md

Store tests

How to test store with MySQL?

  1. Create a database in your MySQL server.
  2. Run the following command with two environment variables set:
DRIVER=mysql DSN=root@/memos_test go test -v ./test/store/...
  • DRIVER should be set to mysql.
  • DSN should be set to the DSN of your MySQL server.