happyz
/
memos
mirror of https://github.com/usememos/memos.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix(frontend): ensure attachments are properly linked when creating memos (#5428) 

Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
lif 2026-01-04 19:17:14 +08:00 committed by GitHub
parent b7b658358e
commit cbbb585b2e
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 12 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
web/src/components/MemoEditor/services/memoService.ts
View File

@ -2,11 +2,21 @@ import { create } from "@bufbuild/protobuf";
import { FieldMaskSchema, timestampDate, timestampFromDate } from "@bufbuild/protobuf/wkt";
import { isEqual } from "lodash-es";
import { memoServiceClient } from "@/connect";
import type { Attachment } from "@/types/proto/api/v1/attachment_service_pb";
import { AttachmentSchema } from "@/types/proto/api/v1/attachment_service_pb";
import type { Memo } from "@/types/proto/api/v1/memo_service_pb";
import { MemoSchema } from "@/types/proto/api/v1/memo_service_pb";
import type { EditorState } from "../state";
import { uploadService } from "./uploadService";
/**
* Converts attachments to reference format for API requests.
* The backend only needs the attachment name to link it to a memo.
*/
function toAttachmentReferences(attachments: Attachment[]): Attachment[] {
return attachments.map((a) => create(AttachmentSchema, { name: a.name }));
}
function buildUpdateMask(
prevMemo: Memo,
state: EditorState,
@ -28,7 +38,7 @@ function buildUpdateMask(
}
if (!isEqual(allAttachments, prevMemo.attachments)) {
mask.add("attachments");
patch.attachments = allAttachments;
patch.attachments = toAttachmentReferences(allAttachments);
}
if (!isEqual(state.metadata.relations, prevMemo.relations)) {
mask.add("relations");
@ -95,7 +105,7 @@ export const memoService = {
const memoData = create(MemoSchema, {
content: state.content,
visibility: state.metadata.visibility,
attachments: allAttachments,
attachments: toAttachmentReferences(allAttachments),
relations: state.metadata.relations,
location: state.metadata.location,
createTime: state.timestamps.createTime ? timestampFromDate(state.timestamps.createTime) : undefined,