From c09ea5a8abe1c73a3f6ec4018ed2d3e107ca140c Mon Sep 17 00:00:00 2001
From: Steven <stevenlgtm@gmail.com>
Date: Wed, 22 Oct 2025 22:41:24 +0800
Subject: [PATCH] chore: remove basic filter support from ListAttachments
 method

---
 server/router/api/v1/attachment_service.go | 24 ----------------------
 1 file changed, 24 deletions(-)

diff --git a/server/router/api/v1/attachment_service.go b/server/router/api/v1/attachment_service.go
index 2a99b8351..40362cf45 100644
--- a/server/router/api/v1/attachment_service.go
+++ b/server/router/api/v1/attachment_service.go
@@ -156,35 +156,11 @@ func (s *APIV1Service) ListAttachments(ctx context.Context, request *v1pb.ListAt
 		Offset:    &offset,
 	}
 
-	// Basic filter support for common cases
-	if request.Filter != "" {
-		// Simple filter parsing - can be enhanced later
-		// For now, support basic type filtering: "type=image/png"
-		if strings.HasPrefix(request.Filter, "type=") {
-			filterType := strings.TrimPrefix(request.Filter, "type=")
-			// Create a temporary struct to hold type filter
-			// Since FindAttachment doesn't have Type field, we'll apply this post-query
-			_ = filterType // We'll filter after getting results
-		}
-	}
-
 	attachments, err := s.Store.ListAttachments(ctx, findAttachment)
 	if err != nil {
 		return nil, status.Errorf(codes.Internal, "failed to list attachments: %v", err)
 	}
 
-	// Apply type filter if specified
-	if request.Filter != "" && strings.HasPrefix(request.Filter, "type=") {
-		filterType := strings.TrimPrefix(request.Filter, "type=")
-		filteredAttachments := make([]*store.Attachment, 0)
-		for _, attachment := range attachments {
-			if attachment.Type == filterType {
-				filteredAttachments = append(filteredAttachments, attachment)
-			}
-		}
-		attachments = filteredAttachments
-	}
-
 	response := &v1pb.ListAttachmentsResponse{}
 
 	for _, attachment := range attachments {