fix(test): use correct InstanceSetting types in user registration tests

- Replace non-existent WorkspaceGeneralSetting with storepb.InstanceSetting
- Use UpsertInstanceSetting instead of non-existent UpsertWorkspaceGeneralSetting
- Remove redundant setting of default registration enabled state
- Fix all compilation errors in user_service_registration_test.go

Fixes golangci-lint errors from GitHub Actions
This commit is contained in:
Claude 2025-11-06 12:22:25 +00:00
parent f5d56b5db7
commit a2a8cddf4d
No known key found for this signature in database
1 changed files with 28 additions and 26 deletions

View File

@ -7,7 +7,7 @@ import (
"github.com/stretchr/testify/require"
apiv1 "github.com/usememos/memos/proto/gen/api/v1"
"github.com/usememos/memos/store"
storepb "github.com/usememos/memos/proto/gen/store"
)
func TestCreateUserRegistration(t *testing.T) {
@ -17,15 +17,10 @@ func TestCreateUserRegistration(t *testing.T) {
ts := NewTestService(t)
defer ts.Cleanup()
// Enable user registration (default)
workspaceSetting := &store.WorkspaceGeneralSetting{
DisallowUserRegistration: false,
}
err := ts.Store.UpsertWorkspaceGeneralSetting(ctx, workspaceSetting)
require.NoError(t, err)
// User registration is enabled by default, no need to set it explicitly
// Create user without authentication - should succeed
_, err = ts.Service.CreateUser(ctx, &apiv1.CreateUserRequest{
_, err := ts.Service.CreateUser(ctx, &apiv1.CreateUserRequest{
User: &apiv1.User{
Username: "newuser",
Email: "newuser@example.com",
@ -40,10 +35,14 @@ func TestCreateUserRegistration(t *testing.T) {
defer ts.Cleanup()
// Disable user registration
workspaceSetting := &store.WorkspaceGeneralSetting{
DisallowUserRegistration: true,
}
err := ts.Store.UpsertWorkspaceGeneralSetting(ctx, workspaceSetting)
_, err := ts.Store.UpsertInstanceSetting(ctx, &storepb.InstanceSetting{
Key: storepb.InstanceSettingKey_GENERAL,
Value: &storepb.InstanceSetting_GeneralSetting{
GeneralSetting: &storepb.InstanceGeneralSetting{
DisallowUserRegistration: true,
},
},
})
require.NoError(t, err)
// Try to create user without authentication - should fail
@ -68,10 +67,14 @@ func TestCreateUserRegistration(t *testing.T) {
hostCtx := ts.CreateUserContext(ctx, hostUser.ID)
// Disable user registration
workspaceSetting := &store.WorkspaceGeneralSetting{
DisallowUserRegistration: true,
}
err = ts.Store.UpsertWorkspaceGeneralSetting(ctx, workspaceSetting)
_, err = ts.Store.UpsertInstanceSetting(ctx, &storepb.InstanceSetting{
Key: storepb.InstanceSettingKey_GENERAL,
Value: &storepb.InstanceSetting_GeneralSetting{
GeneralSetting: &storepb.InstanceGeneralSetting{
DisallowUserRegistration: true,
},
},
})
require.NoError(t, err)
// Host user can create users even when registration is disabled - should succeed
@ -95,10 +98,14 @@ func TestCreateUserRegistration(t *testing.T) {
regularUserCtx := ts.CreateUserContext(ctx, regularUser.ID)
// Disable user registration
workspaceSetting := &store.WorkspaceGeneralSetting{
DisallowUserRegistration: true,
}
err = ts.Store.UpsertWorkspaceGeneralSetting(ctx, workspaceSetting)
_, err = ts.Store.UpsertInstanceSetting(ctx, &storepb.InstanceSetting{
Key: storepb.InstanceSettingKey_GENERAL,
Value: &storepb.InstanceSetting_GeneralSetting{
GeneralSetting: &storepb.InstanceGeneralSetting{
DisallowUserRegistration: true,
},
},
})
require.NoError(t, err)
// Regular user tries to create user when registration is disabled - should fail
@ -140,12 +147,7 @@ func TestCreateUserRegistration(t *testing.T) {
ts := NewTestService(t)
defer ts.Cleanup()
// Enable user registration
workspaceSetting := &store.WorkspaceGeneralSetting{
DisallowUserRegistration: false,
}
err := ts.Store.UpsertWorkspaceGeneralSetting(ctx, workspaceSetting)
require.NoError(t, err)
// User registration is enabled by default
// Unauthenticated user tries to create admin user - role should be ignored
createdUser, err := ts.Service.CreateUser(ctx, &apiv1.CreateUserRequest{