chore: lint with golangci

This commit is contained in:
boojack 2022-07-02 10:44:28 +08:00
parent fbbaba4eda
commit 7a4f36d601
5 changed files with 15 additions and 10 deletions

View File

@ -176,8 +176,7 @@ func (s *Server) registerMemoRoutes(g *echo.Group) {
return echo.NewHTTPError(http.StatusInternalServerError, fmt.Sprintf("Failed to delete memo ID: %v", memoID)).SetInternal(err)
}
c.JSON(http.StatusOK, true)
return nil
return c.JSON(http.StatusOK, true)
})
g.GET("/memo/amount", func(c echo.Context) error {

View File

@ -118,7 +118,10 @@ func (s *Server) registerResourceRoutes(g *echo.Group) {
c.Response().Writer.WriteHeader(http.StatusOK)
c.Response().Writer.Header().Set("Content-Type", resource.Type)
c.Response().Writer.Write(resource.Blob)
if _, err := c.Response().Writer.Write(resource.Blob); err != nil {
return echo.NewHTTPError(http.StatusInternalServerError, "Failed to write resource blob").SetInternal(err)
}
return nil
})
@ -135,7 +138,6 @@ func (s *Server) registerResourceRoutes(g *echo.Group) {
return echo.NewHTTPError(http.StatusInternalServerError, "Failed to delete resource").SetInternal(err)
}
c.JSON(http.StatusOK, true)
return nil
return c.JSON(http.StatusOK, true)
})
}

View File

@ -109,7 +109,6 @@ func (s *Server) registerShortcutRoutes(g *echo.Group) {
return echo.NewHTTPError(http.StatusInternalServerError, "Failed to delete shortcut").SetInternal(err)
}
c.JSON(http.StatusOK, true)
return nil
return c.JSON(http.StatusOK, true)
})
}

View File

@ -261,7 +261,10 @@ func (s *Server) registerWebhookRoutes(g *echo.Group) {
c.Response().Writer.WriteHeader(http.StatusOK)
c.Response().Writer.Header().Set("Content-Type", resource.Type)
c.Response().Writer.Write(resource.Blob)
if _, err := c.Response().Writer.Write(resource.Blob); err != nil {
return echo.NewHTTPError(http.StatusInternalServerError, "Failed to write response").SetInternal(err)
}
return nil
})
}

View File

@ -201,7 +201,7 @@ var minorDirRegexp = regexp.MustCompile(`^migration/[0-9]+\.[0-9]+$`)
func getMinorVersionList() []string {
minorVersionList := []string{}
fs.WalkDir(migrationFS, "migration", func(path string, file fs.DirEntry, err error) error {
if err := fs.WalkDir(migrationFS, "migration", func(path string, file fs.DirEntry, err error) error {
if err != nil {
return err
}
@ -210,7 +210,9 @@ func getMinorVersionList() []string {
}
return nil
})
}); err != nil {
panic(err)
}
sort.Strings(minorVersionList)