From 613e90bd8679415e0bb01b9fc1997dd6ff4b33cd Mon Sep 17 00:00:00 2001 From: Martin MacDonald Date: Thu, 30 May 2024 19:40:56 +0100 Subject: [PATCH] Added logic to delete memo relation and memo comments recursively when a memo is deleted --- server/router/api/v1/memo_service.go | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/server/router/api/v1/memo_service.go b/server/router/api/v1/memo_service.go index 09e71d2cf..43b4f7211 100644 --- a/server/router/api/v1/memo_service.go +++ b/server/router/api/v1/memo_service.go @@ -352,6 +352,11 @@ func (s *APIV1Service) DeleteMemo(ctx context.Context, request *v1pb.DeleteMemoR return nil, status.Errorf(codes.Internal, "failed to delete memo") } + // Delete memo relation + if err := s.Store.DeleteMemoRelation(ctx, &store.DeleteMemoRelation{MemoID: &id}); err != nil { + return nil, status.Errorf(codes.Internal, "failed to delete memo relations") + } + // Delete related resources. resources, err := s.Store.ListResources(ctx, &store.FindResource{MemoID: &id}) if err != nil { @@ -363,6 +368,17 @@ func (s *APIV1Service) DeleteMemo(ctx context.Context, request *v1pb.DeleteMemoR } } + // Delete memo comments + relations, err := s.Store.ListMemoRelations(ctx, &store.FindMemoRelation{RelatedMemoID: &id}) + if err != nil { + return nil, status.Errorf(codes.Internal, "failed to list memo relations") + } + for _, relation := range relations { + if _, err := s.DeleteMemo(ctx, &v1pb.DeleteMemoRequest{Name: fmt.Sprintf("%s%d", MemoNamePrefix, relation.MemoID)}); err != nil { + return nil, status.Errorf(codes.Internal, "failed to delete memo comment") + } + } + return &emptypb.Empty{}, nil }