happyz
/
llama.cpp
mirror of https://github.com/ggerganov/llama.cpp.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Skip experts with zero count (unused)

This commit is contained in:
Ed Addario 2025-11-17 13:06:37 +00:00
parent 63cbcc6dfc
commit fb2b09a43c
No known key found for this signature in database
GPG Key ID: E7875815A3230993
1 changed files with 18 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
tools/imatrix/imatrix.cpp
View File

@ -133,30 +133,40 @@ static std::vector<float> compute_tensor_averages(const Stats & tstats) {
std::vector<float> vec; std::vector<float> vec;
vec.reserve(len); vec.reserve(len);
bool has_valid = false;
if (tstats.activations.empty()) { if (tstats.activations.empty()) {
// Mean of squares // Mean of squares (legacy: only values are available)
for (size_t m = 0; m < n_mat; ++m) { for (size_t m = 0; m < n_mat; ++m) {
const auto c = (float)tstats.counts[m]; const float c = (float) tstats.counts[m];
const size_t off = m * row; const size_t off = m * row;
if (c <= 0.0f) { if (c <= 0.0f) {
vec.insert(vec.end(), row, 0.0f); // zero-fill rows for experts with zero count to preserve shape for (size_t j = 0; j < row; ++j) { vec.push_back(0.0f); }
continue; continue;
} }
for (size_t j = 0; j < row; ++j) { vec.push_back(tstats.values[off + j] / c); }
has_valid = true;
for (size_t j = 0; j < row; ++j) {
vec.push_back(tstats.values[off + j] / c);
}
} }
} else { } else {
// Mean // Mean (new format: activations + values)
for (size_t m = 0; m < n_mat; ++m) { for (size_t m = 0; m < n_mat; ++m) {
const auto c = (float)tstats.counts[m]; const float c = (float) tstats.counts[m];
const size_t off = m * row; const size_t off = m * row;
if (c <= 0.0f) { if (c <= 0.0f) {
vec.insert(vec.end(), row, 0.0f); // zero-fill rows for experts with zero count to preserve shape for (size_t j = 0; j < row; ++j) { vec.push_back(0.0f); }
continue; continue;
} }
for (size_t j = 0; j < row; ++j) { vec.push_back(tstats.activations[off + j] / c); }
has_valid = true;
for (size_t j = 0; j < row; ++j) {
vec.push_back(tstats.activations[off + j] / c);
}
} }
} }
if (!has_valid) { return {}; }
return vec; return vec;
} }