From 97d839c441867d55de22fb91eadfa1a824253684 Mon Sep 17 00:00:00 2001 From: Ed Addario <29247825+EAddario@users.noreply.github.com> Date: Sun, 17 Aug 2025 08:06:15 +0100 Subject: [PATCH 1/2] Using one line per variable definition Co-authored-by: compilade --- tools/imatrix/imatrix.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tools/imatrix/imatrix.cpp b/tools/imatrix/imatrix.cpp index 617e3d4243..610f840e30 100644 --- a/tools/imatrix/imatrix.cpp +++ b/tools/imatrix/imatrix.cpp @@ -268,7 +268,9 @@ static void compute_tensor_statistics(std::vector & tstats) { const auto curr_avg = compute_tensor_averages(ts.stats); const auto prev_avg = compute_tensor_averages(prev->stats); if (curr_avg.size() == prev_avg.size() && !curr_avg.empty()) { - float dot_prod = 0.0f, vec1 = 0.0f, vec2 = 0.0f; + float dot_prod = 0.0f; + float vec1 = 0.0f; + float vec2 = 0.0f; for (size_t i = 0; i < curr_avg.size(); ++i) { dot_prod += curr_avg[i] * prev_avg[i]; vec1 += curr_avg[i] * curr_avg[i]; From d19e6c9afa8791e0fe9090e8ea142e54f016afcf Mon Sep 17 00:00:00 2001 From: Ed Addario <29247825+EAddario@users.noreply.github.com> Date: Sun, 17 Aug 2025 08:08:26 +0100 Subject: [PATCH 2/2] Use { and } around the conditionally-executed statement Co-authored-by: compilade --- tools/imatrix/imatrix.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/imatrix/imatrix.cpp b/tools/imatrix/imatrix.cpp index 610f840e30..7d7aaf609c 100644 --- a/tools/imatrix/imatrix.cpp +++ b/tools/imatrix/imatrix.cpp @@ -223,7 +223,7 @@ static bool compute_vector_statistics(std::vector & tstats, c if (div > 0.0) { for (float w : weights) { const float p = w / div; - if (p > 0.0) entropy -= p * std::log2(p); + if (p > 0.0) { entropy -= p * std::log2(p); } } } }