From efa0bfcdb01dfac0feee674987a0482d50f46145 Mon Sep 17 00:00:00 2001 From: uvos Date: Wed, 11 Mar 2026 23:56:46 +0100 Subject: [PATCH] Update .github/workflows/hip-quality-check.yml MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: Sigbjørn Skjæret --- .github/workflows/hip-quality-check.yml | 17 ++--------------- 1 file changed, 2 insertions(+), 15 deletions(-) diff --git a/.github/workflows/hip-quality-check.yml b/.github/workflows/hip-quality-check.yml index fd299dce22..402a0edd1f 100644 --- a/.github/workflows/hip-quality-check.yml +++ b/.github/workflows/hip-quality-check.yml @@ -52,28 +52,15 @@ jobs: evict-old-files: 1d save: ${{ github.event_name == 'push' && github.ref == 'refs/heads/master' }} - - name: Build with Werror + - name: Build with Werror and check for major VGPR spills id: cmake_build - run: | - cmake -B build -S . \ - -DCMAKE_HIP_COMPILER="$(hipconfig -l)/clang" \ - -DGPU_TARGETS=gfx908 \ - -DGGML_HIP=ON \ - -DGGML_HIP_EXPORT_METRICS=Off \ - -DCMAKE_HIP_FLAGS="-Werror -Wno-tautological-compare" \ - -DCMAKE_BUILD_TYPE=Release - cd build - make -j $(nproc) - - - name: Check for major VGPR spills - id: vgpr_check run: | cmake -B build -S . \ -DCMAKE_HIP_COMPILER="$(hipconfig -l)/clang" \ -DGPU_TARGETS=gfx908 \ -DGGML_HIP=ON \ -DGGML_HIP_EXPORT_METRICS=On \ - -DCMAKE_HIP_FLAGS="" \ + -DCMAKE_HIP_FLAGS="-Werror -Wno-tautological-compare" \ -DCMAKE_BUILD_TYPE=Release cd build make -j $(nproc) 2>&1 | tee metrics.log | grep -v 'Rpass-analysis=kernel-resource-usage\|remark:\|^$'