From e211822fcb88423264ec2f00900f8e81bf20adbf Mon Sep 17 00:00:00 2001 From: Rohan Date: Mon, 29 Sep 2025 16:53:39 +0000 Subject: [PATCH] Address review comment --- tests/test-quantize-fns.cpp | 17 +++++------------ 1 file changed, 5 insertions(+), 12 deletions(-) diff --git a/tests/test-quantize-fns.cpp b/tests/test-quantize-fns.cpp index 521fabade1..c2a4f4db43 100644 --- a/tests/test-quantize-fns.cpp +++ b/tests/test-quantize-fns.cpp @@ -176,21 +176,14 @@ int main(int argc, char * argv[]) { printf("%5s dot product error: %s (%f)\n", ggml_type_name(type), RESULT_STR[failed], vec_dot_error); } - // Test i8mm path (nrc=2) for supported types - if (type == GGML_TYPE_Q4_0 || type == GGML_TYPE_Q4_1 || type == GGML_TYPE_Q8_0 || - type == GGML_TYPE_Q4_K || type == GGML_TYPE_Q6_K) { -#if defined(__ARM_FEATURE_MATMUL_INT8) - const float vec_dot_error_i8mm = dot_product_error(qfns, qfns_cpu, test_size, test_data.data(), test_data2.data(), 2); - failed = !(vec_dot_error_i8mm < max_allowed_error); + // Test nrc=2 path for types that support it + if (qfns_cpu->nrows == 2) { + const float vec_dot_error_nrc2 = dot_product_error(qfns, qfns_cpu, test_size, test_data.data(), test_data2.data(), 2); + failed = !(vec_dot_error_nrc2 < max_allowed_error); num_failed += failed; if (failed || verbose) { - printf("%5s dot product error (i8mm): %s (%f)\n", ggml_type_name(type), RESULT_STR[failed], vec_dot_error_i8mm); + printf("%5s dot product error (nrc=2): %s (%f)\n", ggml_type_name(type), RESULT_STR[failed], vec_dot_error_nrc2); } -#else - if (verbose) { - printf("%5s dot product (i8mm): SKIPPED (not supported)\n", ggml_type_name(type)); - } -#endif } } }