From ddf03c6d9a347c3b7b7577a643d23aaa8d03a7c8 Mon Sep 17 00:00:00 2001 From: Aldehir Rojas Date: Thu, 9 Apr 2026 05:25:07 -0500 Subject: [PATCH] common : fix ambiguous grammar rule in gemma4 (#21661) * common : fix ambiguous grammar rule in gemma4 * cont : fix missing comma... --- common/chat.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/common/chat.cpp b/common/chat.cpp index 1de8a3ba8f..f79fe703db 100644 --- a/common/chat.cpp +++ b/common/chat.cpp @@ -1124,7 +1124,7 @@ static common_chat_params common_chat_params_init_gemma4(const common_chat_templ p.rule("gemma4-bool", p.json_bool()); p.rule("gemma4-null", p.json_null()); p.rule("gemma4-number", p.json_number()); - p.rule("gemma4-dict-key", p.rule("gemma4-dict-key-name", p.until(":")) + p.literal(":")); + p.rule("gemma4-dict-key", p.rule("gemma4-dict-key-name", p.chars("[^:}]", 1, -1)) + p.literal(":")); p.rule("gemma4-dict-kv", p.ref("gemma4-dict-key") + p.space() + p.ref("gemma4-value")); p.rule("gemma4-dict", [&]() { auto ws = p.space();