From dada4c846df5e2bea1800e70b56ceacac7cfb54b Mon Sep 17 00:00:00 2001 From: Daniel Bevenius Date: Fri, 12 Dec 2025 13:25:16 +0100 Subject: [PATCH] model-conversion : remove max diff check in compare-logits [no ci] (#17954) This commit removes the maximum difference check from the compare-logits.py which would stop early if the difference between the logits exceeded a threshold. The motivation for removing this is that it can be useful to be able to get the complete log for debugging/reporting purposes. --- examples/model-conversion/scripts/causal/compare-logits.py | 4 ---- 1 file changed, 4 deletions(-) diff --git a/examples/model-conversion/scripts/causal/compare-logits.py b/examples/model-conversion/scripts/causal/compare-logits.py index afa0d5b263..2744789099 100755 --- a/examples/model-conversion/scripts/causal/compare-logits.py +++ b/examples/model-conversion/scripts/causal/compare-logits.py @@ -32,10 +32,6 @@ def quick_logits_check(pytorch_file, llamacpp_file): print(f"Top 10 llama.cpp logits: {llamacpp_logits[llamacpp_top10]}") print(f"Max absolute difference: {max_diff:.4f}") - if max_diff > 1.0: - print(f"❌ NOK: Large differences detected - max diff: {max_diff:.4f}") - return False - return True def main():