From b4cde7c7d9a9a909efa173ac4b86d60168e3db85 Mon Sep 17 00:00:00 2001 From: megemini Date: Fri, 19 Dec 2025 12:24:55 +0800 Subject: [PATCH 01/10] support PaddleOCR-VL --- common/chat.cpp | 5 +++ convert_hf_to_gguf.py | 42 ++++++++++++++++++++- gguf-py/gguf/constants.py | 3 ++ gguf-py/gguf/gguf_writer.py | 6 +++ gguf-py/gguf/tensor_mapping.py | 3 ++ tools/mtmd/CMakeLists.txt | 1 + tools/mtmd/clip-impl.h | 16 +++++--- tools/mtmd/clip-model.h | 1 + tools/mtmd/clip.cpp | 57 ++++++++++++++++++---------- tools/mtmd/models/models.h | 5 +++ tools/mtmd/models/paddleocr.cpp | 67 +++++++++++++++++++++++++++++++++ tools/mtmd/mtmd.cpp | 4 ++ 12 files changed, 184 insertions(+), 26 deletions(-) create mode 100644 tools/mtmd/models/paddleocr.cpp diff --git a/common/chat.cpp b/common/chat.cpp index 0a426f4478..194299900a 100644 --- a/common/chat.cpp +++ b/common/chat.cpp @@ -601,6 +601,11 @@ common_chat_templates_ptr common_chat_templates_init( "{%- if false %}"); } + // TODO @ngxson : hot fix for PaddleOCR + if (default_template_src.find("<|IMAGE_PLACEHOLDER|>") != std::string::npos) { + string_replace_all(default_template_src, "<|IMAGE_START|><|IMAGE_PLACEHOLDER|><|IMAGE_END|>", ""); + } + std::string token_bos = bos_token_override; std::string token_eos = eos_token_override; bool add_bos = false; diff --git a/convert_hf_to_gguf.py b/convert_hf_to_gguf.py index bd16ba312f..7391e51fce 100755 --- a/convert_hf_to_gguf.py +++ b/convert_hf_to_gguf.py @@ -3602,7 +3602,7 @@ class LLaDAModel(TextModel): yield from super().modify_tensors(data_torch, name, bid) -@ModelBase.register("Ernie4_5_ForCausalLM", "Ernie4_5ForCausalLM") +@ModelBase.register("Ernie4_5_ForCausalLM", "Ernie4_5ForCausalLM", "PaddleOCRVLForConditionalGeneration") class Ernie4_5Model(TextModel): model_arch = gguf.MODEL_ARCH.ERNIE4_5 @@ -3618,6 +3618,10 @@ class Ernie4_5Model(TextModel): if (head_dim := self.hparams.get("head_dim")) is None: head_dim = self.hparams["hidden_size"] // num_heads + if "mlp_AR" in name or "vision_model" in name: + # skip vision model and projector tensors + return [] + if "ernie." in name: name = name.replace("ernie.", "model.") # split the qkv weights @@ -3735,6 +3739,42 @@ class Ernie4_5MoeModel(Ernie4_5Model): if len(experts) > 0: raise ValueError(f"Unprocessed experts: {experts}") +@ModelBase.register("PaddleOCRVisionModel") +class PaddleOCRVisionModel(MmprojModel): + # PaddleOCR-VL uses a modified version of Siglip + min_pixels: int = 0 + max_pixels: int = 0 + + def __init__(self, *args, **kwargs): + super().__init__(*args, **kwargs) + assert self.hparams_vision is not None + self.min_pixels = self.preprocessor_config["min_pixels"] + self.max_pixels = self.preprocessor_config["max_pixels"] + self.hparams_vision["image_size"] = int(math.sqrt(self.max_pixels)) + + def set_gguf_parameters(self): + super().set_gguf_parameters() + assert self.hparams_vision is not None + hparams = self.hparams_vision + self.gguf_writer.add_clip_projector_type(gguf.VisionProjectorType.PADDLEOCR) + self.gguf_writer.add_vision_max_pixels(self.max_pixels) + self.gguf_writer.add_vision_min_pixels(self.min_pixels) + self.gguf_writer.add_vision_use_gelu(True) + self.gguf_writer.add_vision_attention_layernorm_eps(hparams.get("rms_norm_eps", 1e-6)) + + def modify_tensors(self, data_torch: Tensor, name: str, bid: int | None) -> Iterable[tuple[str, Tensor]]: + del bid # unused + name = name.replace("visual.", "model.") + + if "vision_model" in name or "mlp_AR" in name: + if "packing_position_embedding" in name: + return [] # unused + elif "vision_model.head" in name: + # we don't yet support image embeddings for this model + return [] + else: + return [(self.map_tensor_name(name), data_torch)] + return [] # skip other tensors @ModelBase.register( "Qwen2VLModel", diff --git a/gguf-py/gguf/constants.py b/gguf-py/gguf/constants.py index fed0e94dcf..1ff70cbf49 100644 --- a/gguf-py/gguf/constants.py +++ b/gguf-py/gguf/constants.py @@ -281,6 +281,8 @@ class Keys: class ClipVision: IMAGE_SIZE = "clip.vision.image_size" + MAX_PIXELS = "clip.vision.max_pixels" + MIN_PIXELS = "clip.vision.min_pixels" PREPROC_IMAGE_SIZE = "clip.vision.preproc_image_size" PATCH_SIZE = "clip.vision.patch_size" EMBEDDING_LENGTH = "clip.vision.embedding_length" @@ -3360,6 +3362,7 @@ class VisionProjectorType: VOXTRAL = "voxtral" LFM2 = "lfm2" KIMIVL = "kimivl" + PADDLEOCR = "paddleocr" LIGHTONOCR = "lightonocr" COGVLM = "cogvlm" JANUS_PRO = "janus_pro" diff --git a/gguf-py/gguf/gguf_writer.py b/gguf-py/gguf/gguf_writer.py index 9e6ff3ac77..93c4b00572 100644 --- a/gguf-py/gguf/gguf_writer.py +++ b/gguf-py/gguf/gguf_writer.py @@ -1085,6 +1085,12 @@ class GGUFWriter: def add_vision_embedding_length(self, value: int) -> None: self.add_uint32(Keys.ClipVision.EMBEDDING_LENGTH, value) + def add_vision_max_pixels(self, value: int) -> None: + self.add_uint32(Keys.ClipVision.MAX_PIXELS, value) + + def add_vision_min_pixels(self, value: int) -> None: + self.add_uint32(Keys.ClipVision.MIN_PIXELS, value) + def add_vision_feed_forward_length(self, value: int) -> None: self.add_uint32(Keys.ClipVision.FEED_FORWARD_LENGTH, value) diff --git a/gguf-py/gguf/tensor_mapping.py b/gguf-py/gguf/tensor_mapping.py index e04ff11164..8e0d35e423 100644 --- a/gguf-py/gguf/tensor_mapping.py +++ b/gguf-py/gguf/tensor_mapping.py @@ -1207,6 +1207,7 @@ class TensorNameMap: MODEL_TENSOR.V_MMPROJ: ( "multi_modal_projector.linear_{bid}", "visual.merger.mlp.{bid}", # qwen2vl + "mlp_AR.linear_{bid}", # PaddleOCR-VL ), MODEL_TENSOR.V_MMPROJ_FC: ( @@ -1432,6 +1433,7 @@ class TensorNameMap: "multi_modal_projector.pre_norm", "pre_mm_projector_norm", "model.vision.linear_proj.norm1", # cogvlm + "mlp_AR.pre_norm", # PaddleOCR-VL ), MODEL_TENSOR.V_MM_SOFT_EMB_NORM: ( @@ -1456,6 +1458,7 @@ class TensorNameMap: MODEL_TENSOR.V_RESMPL_ATTN_OUT: ( "resampler.attn.out_proj", + "model.vision_model.head.attention.out_proj", ), MODEL_TENSOR.V_RESMPL_KV: ( diff --git a/tools/mtmd/CMakeLists.txt b/tools/mtmd/CMakeLists.txt index e7f3067a16..4f0e9173c3 100644 --- a/tools/mtmd/CMakeLists.txt +++ b/tools/mtmd/CMakeLists.txt @@ -21,6 +21,7 @@ add_library(mtmd models/llama4.cpp models/llava.cpp models/minicpmv.cpp + models/paddleocr.cpp models/pixtral.cpp models/qwen2vl.cpp models/qwen3vl.cpp diff --git a/tools/mtmd/clip-impl.h b/tools/mtmd/clip-impl.h index d75233cc0a..ca2386119a 100644 --- a/tools/mtmd/clip-impl.h +++ b/tools/mtmd/clip-impl.h @@ -109,12 +109,14 @@ #define TN_DEEPSTACK_FC2 "v.deepstack.%d.fc2.%s" // qwen3vl deepstack // mimicpmv -#define TN_MINICPMV_POS_EMBD_K "resampler.pos_embed_k" -#define TN_MINICPMV_QUERY "resampler.query" -#define TN_MINICPMV_PROJ "resampler.proj.weight" -#define TN_MINICPMV_KV_PROJ "resampler.kv.weight" -#define TN_MINICPMV_ATTN "resampler.attn.%s.%s" -#define TN_MINICPMV_LN "resampler.ln_%s.%s" +#define TN_RESAMPL_POS_EMBD_K "resampler.pos_embed_k" +#define TN_RESAMPL_QUERY "resampler.query" +#define TN_RESAMPL_PROJ "resampler.proj.weight" +#define TN_RESAMPL_KV_PROJ "resampler.kv.weight" +#define TN_RESAMPL_ATTN "resampler.attn.%s.%s" +#define TN_RESAMPL_LN "resampler.ln_%s.%s" +#define TN_RESAMPL_FFN_UP "resampler.ffn_up.%s" +#define TN_RESAMPL_FFN_DOWN "resampler.ffn_down.%s" #define TN_GLM_ADAPER_CONV "adapter.conv.%s" #define TN_GLM_ADAPTER_LINEAR "adapter.linear.linear.%s" @@ -167,6 +169,7 @@ enum projector_type { PROJECTOR_TYPE_VOXTRAL, PROJECTOR_TYPE_LFM2, PROJECTOR_TYPE_KIMIVL, + PROJECTOR_TYPE_PADDLEOCR, PROJECTOR_TYPE_LIGHTONOCR, PROJECTOR_TYPE_COGVLM, PROJECTOR_TYPE_JANUS_PRO, @@ -195,6 +198,7 @@ static std::map PROJECTOR_TYPE_NAMES = { { PROJECTOR_TYPE_VOXTRAL, "voxtral"}, { PROJECTOR_TYPE_LFM2, "lfm2"}, { PROJECTOR_TYPE_KIMIVL, "kimivl"}, + { PROJECTOR_TYPE_PADDLEOCR, "paddleocr"}, { PROJECTOR_TYPE_LIGHTONOCR,"lightonocr"}, { PROJECTOR_TYPE_COGVLM, "cogvlm"}, { PROJECTOR_TYPE_JANUS_PRO, "janus_pro"}, diff --git a/tools/mtmd/clip-model.h b/tools/mtmd/clip-model.h index f5c41ff138..8ef04b6b2b 100644 --- a/tools/mtmd/clip-model.h +++ b/tools/mtmd/clip-model.h @@ -39,6 +39,7 @@ struct clip_hparams { int32_t image_min_pixels = -1; int32_t image_max_pixels = -1; int32_t n_merge = 0; // number of patch merges **per-side** + int32_t proj_scale_factor = 0; float image_mean[3]; float image_std[3]; diff --git a/tools/mtmd/clip.cpp b/tools/mtmd/clip.cpp index 35e3aef0ab..ffea7fd9bd 100644 --- a/tools/mtmd/clip.cpp +++ b/tools/mtmd/clip.cpp @@ -825,6 +825,10 @@ static ggml_cgraph * clip_image_build_graph(clip_ctx * ctx, const clip_image_f32 { builder = std::make_unique(ctx, img); } break; + case PROJECTOR_TYPE_PADDLEOCR: + { + builder = std::make_unique(ctx, img); + } break; case PROJECTOR_TYPE_COGVLM: { builder = std::make_unique(ctx, img); @@ -1187,6 +1191,10 @@ struct clip_model_loader { hparams.audio_window_len = 400; hparams.audio_hop_len = 160; } break; + case PROJECTOR_TYPE_PADDLEOCR: + { + hparams.proj_scale_factor = 2; + } break; default: break; } @@ -1432,25 +1440,25 @@ struct clip_model_loader { } break; case PROJECTOR_TYPE_MINICPMV: { - // model.mm_model_pos_embed = get_tensor(new_clip->ctx_data, TN_MINICPMV_POS_EMBD); - model.mm_model_pos_embed_k = get_tensor(TN_MINICPMV_POS_EMBD_K); - model.mm_model_query = get_tensor(TN_MINICPMV_QUERY); - model.mm_model_proj = get_tensor(TN_MINICPMV_PROJ); - model.mm_model_kv_proj = get_tensor(TN_MINICPMV_KV_PROJ); - model.mm_model_attn_q_w = get_tensor(string_format(TN_MINICPMV_ATTN, "q", "weight")); - model.mm_model_attn_k_w = get_tensor(string_format(TN_MINICPMV_ATTN, "k", "weight")); - model.mm_model_attn_v_w = get_tensor(string_format(TN_MINICPMV_ATTN, "v", "weight")); - model.mm_model_attn_q_b = get_tensor(string_format(TN_MINICPMV_ATTN, "q", "bias")); - model.mm_model_attn_k_b = get_tensor(string_format(TN_MINICPMV_ATTN, "k", "bias")); - model.mm_model_attn_v_b = get_tensor(string_format(TN_MINICPMV_ATTN, "v", "bias")); - model.mm_model_attn_o_w = get_tensor(string_format(TN_MINICPMV_ATTN, "out", "weight")); - model.mm_model_attn_o_b = get_tensor(string_format(TN_MINICPMV_ATTN, "out", "bias")); - model.mm_model_ln_q_w = get_tensor(string_format(TN_MINICPMV_LN, "q", "weight")); - model.mm_model_ln_q_b = get_tensor(string_format(TN_MINICPMV_LN, "q", "bias")); - model.mm_model_ln_kv_w = get_tensor(string_format(TN_MINICPMV_LN, "kv", "weight")); - model.mm_model_ln_kv_b = get_tensor(string_format(TN_MINICPMV_LN, "kv", "bias")); - model.mm_model_ln_post_w = get_tensor(string_format(TN_MINICPMV_LN, "post", "weight")); - model.mm_model_ln_post_b = get_tensor(string_format(TN_MINICPMV_LN, "post", "bias")); + // model.mm_model_pos_embed = get_tensor(new_clip->ctx_data, TN_RESAMPL_POS_EMBD); + model.mm_model_pos_embed_k = get_tensor(TN_RESAMPL_POS_EMBD_K); + model.mm_model_query = get_tensor(TN_RESAMPL_QUERY); + model.mm_model_proj = get_tensor(TN_RESAMPL_PROJ); + model.mm_model_kv_proj = get_tensor(TN_RESAMPL_KV_PROJ); + model.mm_model_attn_q_w = get_tensor(string_format(TN_RESAMPL_ATTN, "q", "weight")); + model.mm_model_attn_k_w = get_tensor(string_format(TN_RESAMPL_ATTN, "k", "weight")); + model.mm_model_attn_v_w = get_tensor(string_format(TN_RESAMPL_ATTN, "v", "weight")); + model.mm_model_attn_q_b = get_tensor(string_format(TN_RESAMPL_ATTN, "q", "bias")); + model.mm_model_attn_k_b = get_tensor(string_format(TN_RESAMPL_ATTN, "k", "bias")); + model.mm_model_attn_v_b = get_tensor(string_format(TN_RESAMPL_ATTN, "v", "bias")); + model.mm_model_attn_o_w = get_tensor(string_format(TN_RESAMPL_ATTN, "out", "weight")); + model.mm_model_attn_o_b = get_tensor(string_format(TN_RESAMPL_ATTN, "out", "bias")); + model.mm_model_ln_q_w = get_tensor(string_format(TN_RESAMPL_LN, "q", "weight")); + model.mm_model_ln_q_b = get_tensor(string_format(TN_RESAMPL_LN, "q", "bias")); + model.mm_model_ln_kv_w = get_tensor(string_format(TN_RESAMPL_LN, "kv", "weight")); + model.mm_model_ln_kv_b = get_tensor(string_format(TN_RESAMPL_LN, "kv", "bias")); + model.mm_model_ln_post_w = get_tensor(string_format(TN_RESAMPL_LN, "post", "weight")); + model.mm_model_ln_post_b = get_tensor(string_format(TN_RESAMPL_LN, "post", "bias")); } break; case PROJECTOR_TYPE_GLM_EDGE: { @@ -1505,6 +1513,7 @@ struct clip_model_loader { } break; case PROJECTOR_TYPE_LFM2: case PROJECTOR_TYPE_KIMIVL: + case PROJECTOR_TYPE_PADDLEOCR: { model.mm_input_norm_w = get_tensor(TN_MM_INP_NORM); model.mm_input_norm_b = get_tensor(TN_MM_INP_NORM_B); @@ -2701,6 +2710,7 @@ bool clip_image_preprocess(struct clip_ctx * ctx, const clip_image_u8 * img, str } break; case PROJECTOR_TYPE_PIXTRAL: + case PROJECTOR_TYPE_PADDLEOCR: case PROJECTOR_TYPE_LIGHTONOCR: { GGML_ASSERT(params.image_min_pixels > 0 && params.image_max_pixels > 0); @@ -2956,6 +2966,13 @@ int clip_n_output_tokens(const struct clip_ctx * ctx, struct clip_image_f32 * im int y_patch = CLIP_ALIGN(img->ny, out_patch_size) / out_patch_size; n_patches = x_patch * y_patch; } break; + case PROJECTOR_TYPE_PADDLEOCR: + { + // dynamic size + int scale_factor = ctx->model.hparams.proj_scale_factor; + int stride = scale_factor * scale_factor; + n_patches = CLIP_ALIGN(n_patches, stride) / stride; + } break; case PROJECTOR_TYPE_PIXTRAL: case PROJECTOR_TYPE_LIGHTONOCR: { @@ -3285,6 +3302,7 @@ bool clip_image_batch_encode(clip_ctx * ctx, const int n_threads, const clip_ima } break; case PROJECTOR_TYPE_PIXTRAL: case PROJECTOR_TYPE_KIMIVL: + case PROJECTOR_TYPE_PADDLEOCR: case PROJECTOR_TYPE_LIGHTONOCR: { // set the 2D positions @@ -3453,6 +3471,7 @@ int clip_n_mmproj_embd(const struct clip_ctx * ctx) { return ctx->model.mm_2_w->ne[1]; case PROJECTOR_TYPE_LFM2: case PROJECTOR_TYPE_KIMIVL: + case PROJECTOR_TYPE_PADDLEOCR: return ctx->model.mm_2_w->ne[1]; case PROJECTOR_TYPE_COGVLM: return ctx->model.mm_4h_to_h_w->ne[1]; diff --git a/tools/mtmd/models/models.h b/tools/mtmd/models/models.h index 0496d6b22f..d8dd1d1042 100644 --- a/tools/mtmd/models/models.h +++ b/tools/mtmd/models/models.h @@ -42,6 +42,11 @@ struct clip_graph_kimivl : clip_graph { ggml_cgraph * build() override; }; +struct clip_graph_paddleocr : clip_graph { + clip_graph_paddleocr(clip_ctx * ctx, const clip_image_f32 & img) : clip_graph(ctx, img) {} + ggml_cgraph * build() override; +}; + struct clip_graph_cogvlm : clip_graph { clip_graph_cogvlm(clip_ctx * ctx, const clip_image_f32 & img) : clip_graph(ctx, img) {} ggml_cgraph * build() override; diff --git a/tools/mtmd/models/paddleocr.cpp b/tools/mtmd/models/paddleocr.cpp new file mode 100644 index 0000000000..ed8988ffef --- /dev/null +++ b/tools/mtmd/models/paddleocr.cpp @@ -0,0 +1,67 @@ +#include "models.h" + +ggml_cgraph * clip_graph_paddleocr::build() { + // 2D input positions + ggml_tensor * pos_h = ggml_new_tensor_1d(ctx0, GGML_TYPE_I32, n_patches); + ggml_set_name(pos_h, "pos_h"); + ggml_set_input(pos_h); + + ggml_tensor * pos_w = ggml_new_tensor_1d(ctx0, GGML_TYPE_I32, n_patches); + ggml_set_name(pos_w, "pos_w"); + ggml_set_input(pos_w); + + ggml_tensor * learned_pos_embd = resize_position_embeddings(); + + // build ViT with 2D position embeddings + auto add_pos = [&](ggml_tensor * cur, const clip_layer &) { + // first half is X axis and second half is Y axis + return build_rope_2d(ctx0, cur, pos_w, pos_h, hparams.rope_theta, false); + }; + + ggml_tensor * inp = build_inp(); + ggml_tensor * cur = build_vit( + inp, n_patches, + NORM_TYPE_NORMAL, + hparams.ffn_op, + learned_pos_embd, + add_pos); + + cb(cur, "vit_out", -1); + + { + // mlp_AR + float proj_norm_eps = 1e-5; // PaddleOCR uses hard-coded value eps=1e-5 for Projector + cur = build_norm(cur, + model.mm_input_norm_w, model.mm_input_norm_b, + NORM_TYPE_NORMAL, proj_norm_eps, -1); + //cur = build_patch_merge_permute(cur, hparams.proj_scale_factor); + + // stack and padding + int64_t stride = hparams.proj_scale_factor * hparams.proj_scale_factor; + int64_t n_embd = cur->ne[0]; + int64_t n_tokens = cur->ne[1]; + int64_t n_tokens_padded = CLIP_ALIGN(n_tokens, stride); + int64_t n_pad = n_tokens_padded - n_tokens; + if (n_pad > 0) { + cur = ggml_view_1d(ctx0, cur, ggml_nelements(cur), 0); + cur = ggml_pad(ctx0, cur, n_pad * n_embd, 0, 0, 0); + } + cur = ggml_view_2d(ctx0, cur, + n_embd * stride, + n_tokens_padded / stride, + ggml_row_size(cur->type, n_embd * stride), 0); + cb(cur, "after_stacked", -1); + + cur = build_ffn(cur, + model.mm_1_w, model.mm_1_b, + nullptr, nullptr, + model.mm_2_w, model.mm_2_b, + hparams.ffn_op, -1); + cb(cur, "mlp_out", -1); + } + + // build the graph + ggml_build_forward_expand(gf, cur); + + return gf; +} diff --git a/tools/mtmd/mtmd.cpp b/tools/mtmd/mtmd.cpp index 2638fe4fc5..c386bf07c3 100644 --- a/tools/mtmd/mtmd.cpp +++ b/tools/mtmd/mtmd.cpp @@ -313,6 +313,10 @@ struct mtmd_context { img_beg = "<|begin_of_image|>"; img_end = "<|end_of_image|>"; + } else if (proj == PROJECTOR_TYPE_PADDLEOCR) { + // <|IMAGE_START|> ... (image embeddings) ... <|IMAGE_END|> + img_beg = "<|IMAGE_START|>"; + img_end = "<|IMAGE_END|>"; } } From 64f0a46e1cabcdd04e713752582268bfaf52a9ae Mon Sep 17 00:00:00 2001 From: megemini Date: Fri, 19 Dec 2025 12:51:29 +0800 Subject: [PATCH 02/10] clip: update PaddleOCR model loader parameters to prevent OOM during warmup --- tools/mtmd/clip.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/mtmd/clip.cpp b/tools/mtmd/clip.cpp index ffea7fd9bd..cc022ad2e0 100644 --- a/tools/mtmd/clip.cpp +++ b/tools/mtmd/clip.cpp @@ -1194,6 +1194,8 @@ struct clip_model_loader { case PROJECTOR_TYPE_PADDLEOCR: { hparams.proj_scale_factor = 2; + hparams.set_limit_image_tokens(8, 1024); + hparams.set_warmup_n_tokens(256); // avoid OOM on warmup } break; default: break; From fbfa90691043274320d5991cde2783eb558d3ebb Mon Sep 17 00:00:00 2001 From: megemini Date: Mon, 12 Jan 2026 21:50:49 +0800 Subject: [PATCH 03/10] [update] add paddleocr vl text model instead of ernie4.5 --- common/chat.cpp | 5 -- convert_hf_to_gguf.py | 16 ++++- gguf-py/gguf/constants.py | 16 +++++ src/CMakeLists.txt | 1 + src/llama-arch.cpp | 2 + src/llama-arch.h | 1 + src/llama-model.cpp | 10 +++ src/llama-vocab.cpp | 1 + src/models/models.h | 4 ++ src/models/paddleocr.cpp | 119 ++++++++++++++++++++++++++++++++ tools/mtmd/clip-model.h | 1 - tools/mtmd/clip.cpp | 40 +++++++++-- tools/mtmd/models/paddleocr.cpp | 46 +++++------- 13 files changed, 219 insertions(+), 43 deletions(-) create mode 100644 src/models/paddleocr.cpp diff --git a/common/chat.cpp b/common/chat.cpp index 194299900a..0a426f4478 100644 --- a/common/chat.cpp +++ b/common/chat.cpp @@ -601,11 +601,6 @@ common_chat_templates_ptr common_chat_templates_init( "{%- if false %}"); } - // TODO @ngxson : hot fix for PaddleOCR - if (default_template_src.find("<|IMAGE_PLACEHOLDER|>") != std::string::npos) { - string_replace_all(default_template_src, "<|IMAGE_START|><|IMAGE_PLACEHOLDER|><|IMAGE_END|>", ""); - } - std::string token_bos = bos_token_override; std::string token_eos = eos_token_override; bool add_bos = false; diff --git a/convert_hf_to_gguf.py b/convert_hf_to_gguf.py index 7391e51fce..83eb8a7e7c 100755 --- a/convert_hf_to_gguf.py +++ b/convert_hf_to_gguf.py @@ -3602,13 +3602,20 @@ class LLaDAModel(TextModel): yield from super().modify_tensors(data_torch, name, bid) -@ModelBase.register("Ernie4_5_ForCausalLM", "Ernie4_5ForCausalLM", "PaddleOCRVLForConditionalGeneration") +@ModelBase.register("Ernie4_5_ForCausalLM", "Ernie4_5ForCausalLM") class Ernie4_5Model(TextModel): model_arch = gguf.MODEL_ARCH.ERNIE4_5 def set_vocab(self): self._set_vocab_sentencepiece() + tokenizer_config_file = self.dir_model / 'tokenizer_config.json' + if tokenizer_config_file.is_file(): + with open(tokenizer_config_file, "r", encoding="utf-8") as f: + tokenizer_config_json = json.load(f) + if "add_prefix_space" in tokenizer_config_json: + self.gguf_writer.add_add_space_prefix(tokenizer_config_json["add_prefix_space"]) + def set_gguf_parameters(self): super().set_gguf_parameters() @@ -3739,6 +3746,12 @@ class Ernie4_5MoeModel(Ernie4_5Model): if len(experts) > 0: raise ValueError(f"Unprocessed experts: {experts}") + +@ModelBase.register("PaddleOCRVLForConditionalGeneration") +class PaddleOCRModel(Ernie4_5Model): + model_arch = gguf.MODEL_ARCH.PADDLEOCR + + @ModelBase.register("PaddleOCRVisionModel") class PaddleOCRVisionModel(MmprojModel): # PaddleOCR-VL uses a modified version of Siglip @@ -3776,6 +3789,7 @@ class PaddleOCRVisionModel(MmprojModel): return [(self.map_tensor_name(name), data_torch)] return [] # skip other tensors + @ModelBase.register( "Qwen2VLModel", "Qwen2VLForConditionalGeneration", diff --git a/gguf-py/gguf/constants.py b/gguf-py/gguf/constants.py index 1ff70cbf49..197292206e 100644 --- a/gguf-py/gguf/constants.py +++ b/gguf-py/gguf/constants.py @@ -449,6 +449,7 @@ class MODEL_ARCH(IntEnum): RND1 = auto() PANGU_EMBED = auto() MISTRAL3 = auto() + PADDLEOCR = auto() class VISION_PROJECTOR_TYPE(IntEnum): @@ -826,6 +827,7 @@ MODEL_ARCH_NAMES: dict[MODEL_ARCH, str] = { MODEL_ARCH.RND1: "rnd1", MODEL_ARCH.PANGU_EMBED: "pangu-embedded", MODEL_ARCH.MISTRAL3: "mistral3", + MODEL_ARCH.PADDLEOCR: "paddleocr", } VISION_PROJECTOR_TYPE_NAMES: dict[VISION_PROJECTOR_TYPE, str] = { @@ -2827,6 +2829,20 @@ MODEL_TENSORS: dict[MODEL_ARCH, list[MODEL_TENSOR]] = { MODEL_TENSOR.FFN_DOWN, MODEL_TENSOR.FFN_UP, ], + MODEL_ARCH.PADDLEOCR: [ + MODEL_TENSOR.TOKEN_EMBD, + MODEL_TENSOR.OUTPUT_NORM, + MODEL_TENSOR.OUTPUT, + MODEL_TENSOR.ATTN_NORM, + MODEL_TENSOR.ATTN_Q, + MODEL_TENSOR.ATTN_K, + MODEL_TENSOR.ATTN_V, + MODEL_TENSOR.ATTN_OUT, + MODEL_TENSOR.FFN_NORM, + MODEL_TENSOR.FFN_GATE, + MODEL_TENSOR.FFN_DOWN, + MODEL_TENSOR.FFN_UP, + ], MODEL_ARCH.FALCON_H1: [ # Token embedding MODEL_TENSOR.TOKEN_EMBD, diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt index 4192af7c0c..353a4ed608 100644 --- a/src/CMakeLists.txt +++ b/src/CMakeLists.txt @@ -60,6 +60,7 @@ add_library(llama models/dream.cpp models/ernie4-5-moe.cpp models/ernie4-5.cpp + models/paddleocr.cpp models/exaone.cpp models/exaone4.cpp models/falcon-h1.cpp diff --git a/src/llama-arch.cpp b/src/llama-arch.cpp index 8caf80afcf..48eaefcb49 100644 --- a/src/llama-arch.cpp +++ b/src/llama-arch.cpp @@ -114,6 +114,7 @@ static const std::map LLM_ARCH_NAMES = { { LLM_ARCH_RND1, "rnd1" }, { LLM_ARCH_PANGU_EMBED, "pangu-embedded" }, { LLM_ARCH_MISTRAL3, "mistral3" }, + { LLM_ARCH_PADDLEOCR, "paddleocr" }, { LLM_ARCH_UNKNOWN, "(unknown)" }, }; @@ -700,6 +701,7 @@ static std::set llm_get_tensor_names(llm_arch arch) { case LLM_ARCH_INTERNLM2: case LLM_ARCH_GRANITE: case LLM_ARCH_ERNIE4_5: + case LLM_ARCH_PADDLEOCR: case LLM_ARCH_SMOLLM3: case LLM_ARCH_DREAM: case LLM_ARCH_LLADA: diff --git a/src/llama-arch.h b/src/llama-arch.h index 6cbf9b1f89..0ce3993886 100644 --- a/src/llama-arch.h +++ b/src/llama-arch.h @@ -118,6 +118,7 @@ enum llm_arch { LLM_ARCH_RND1, LLM_ARCH_PANGU_EMBED, LLM_ARCH_MISTRAL3, + LLM_ARCH_PADDLEOCR, LLM_ARCH_UNKNOWN, }; diff --git a/src/llama-model.cpp b/src/llama-model.cpp index c9a3c5dfa2..f83991ef62 100644 --- a/src/llama-model.cpp +++ b/src/llama-model.cpp @@ -2056,7 +2056,11 @@ void llama_model::load_hparams(llama_model_loader & ml) { } break; case LLM_ARCH_ERNIE4_5: case LLM_ARCH_ERNIE4_5_MOE: + case LLM_ARCH_PADDLEOCR: { + // paddleocr need mrope_section + ml.get_key_or_arr(LLM_KV_ROPE_DIMENSION_SECTIONS, hparams.rope_sections, 4, false); + ml.get_key(LLM_KV_ATTENTION_LAYERNORM_RMS_EPS, hparams.f_norm_rms_eps); if (arch == LLM_ARCH_ERNIE4_5_MOE) { ml.get_key(LLM_KV_EXPERT_FEED_FORWARD_LENGTH, hparams.n_ff_exp); @@ -5964,6 +5968,7 @@ bool llama_model::load_tensors(llama_model_loader & ml) { } break; case LLM_ARCH_ERNIE4_5: case LLM_ARCH_ERNIE4_5_MOE: + case LLM_ARCH_PADDLEOCR: { tok_embd = create_tensor(tn(LLM_TENSOR_TOKEN_EMBD, "weight"), {n_embd, n_vocab}, 0); @@ -7574,6 +7579,10 @@ ggml_cgraph * llama_model::build_graph(const llm_graph_params & params) const { { llm = std::make_unique(*this, params); } break; + case LLM_ARCH_PADDLEOCR: + { + llm = std::make_unique(*this, params); + } break; case LLM_ARCH_HUNYUAN_MOE: { llm = std::make_unique(*this, params); @@ -7866,6 +7875,7 @@ llama_rope_type llama_model_rope_type(const llama_model * model) { return LLAMA_ROPE_TYPE_NEOX; case LLM_ARCH_QWEN2VL: + case LLM_ARCH_PADDLEOCR: return LLAMA_ROPE_TYPE_MROPE; case LLM_ARCH_QWEN3VL: case LLM_ARCH_QWEN3VLMOE: diff --git a/src/llama-vocab.cpp b/src/llama-vocab.cpp index 7b01a2edfe..b00885670e 100644 --- a/src/llama-vocab.cpp +++ b/src/llama-vocab.cpp @@ -2359,6 +2359,7 @@ void llama_vocab::impl::load(llama_model_loader & ml, const LLM_KV & kv) { || t.first == "<|call|>" // o200k_harmony || t.first == "" || t.first == "<|endoftext|>" + || t.first == "" // paddleocr || t.first == "<|eom_id|>" || t.first == "" || t.first == "_" diff --git a/src/models/models.h b/src/models/models.h index ffb36acc61..dcef35473c 100644 --- a/src/models/models.h +++ b/src/models/models.h @@ -158,6 +158,10 @@ struct llm_build_ernie4_5_moe : public llm_graph_context { llm_build_ernie4_5_moe(const llama_model & model, const llm_graph_params & params); }; +struct llm_build_paddleocr : public llm_graph_context { + llm_build_paddleocr(const llama_model & model, const llm_graph_params & params); +}; + template struct llm_build_exaone4 : public llm_graph_context { llm_build_exaone4(const llama_model & model, const llm_graph_params & params); diff --git a/src/models/paddleocr.cpp b/src/models/paddleocr.cpp new file mode 100644 index 0000000000..1f6336eb97 --- /dev/null +++ b/src/models/paddleocr.cpp @@ -0,0 +1,119 @@ +#include "models.h" + +llm_build_paddleocr::llm_build_paddleocr(const llama_model & model, const llm_graph_params & params) : + llm_graph_context(params) { + const int64_t n_embd_head = hparams.n_embd_head_v; + + GGML_ASSERT(n_embd_head == hparams.n_embd_head_k); + GGML_ASSERT(n_embd_head == hparams.n_rot); + + ggml_tensor * cur; + ggml_tensor * inpL; + + inpL = build_inp_embd(model.tok_embd); + + int sections[4]; + std::copy(std::begin(hparams.rope_sections), std::begin(hparams.rope_sections) + 4, sections); + + // inp_pos - contains the positions + ggml_tensor * inp_pos = build_inp_pos(); + + auto * inp_attn = build_attn_inp_kv(); + + ggml_tensor * inp_out_ids = build_inp_out_ids(); + + for (int il = 0; il < n_layer; ++il) { + ggml_tensor * inpSA = inpL; + + // norm + { + cur = build_norm(inpL, model.layers[il].attn_norm, NULL, LLM_NORM_RMS, il); + cb(cur, "attn_norm", il); + } + // self-attention + { + ggml_tensor * Qcur = build_lora_mm(model.layers[il].wq, cur); + cb(Qcur, "Qcur", il); + if (model.layers[il].bq) { + Qcur = ggml_add(ctx0, Qcur, model.layers[il].bq); + cb(Qcur, "Qcur", il); + } + ggml_tensor * Kcur = build_lora_mm(model.layers[il].wk, cur); + cb(Kcur, "Kcur", il); + if (model.layers[il].bk) { + Kcur = ggml_add(ctx0, Kcur, model.layers[il].bk); + cb(Kcur, "Kcur", il); + } + ggml_tensor * Vcur = build_lora_mm(model.layers[il].wv, cur); + cb(Vcur, "Vcur", il); + if (model.layers[il].bv) { + Vcur = ggml_add(ctx0, Vcur, model.layers[il].bv); + cb(Vcur, "Vcur", il); + } + Qcur = ggml_reshape_3d(ctx0, Qcur, n_embd_head, n_head, n_tokens); + Kcur = ggml_reshape_3d(ctx0, Kcur, n_embd_head, n_head_kv, n_tokens); + Vcur = ggml_reshape_3d(ctx0, Vcur, n_embd_head, n_head_kv, n_tokens); + + Qcur = ggml_rope_multi( + ctx0, Qcur, inp_pos, nullptr, + n_rot, sections, rope_type, n_ctx_orig, freq_base, freq_scale, + ext_factor, attn_factor, beta_fast, beta_slow + ); + + Kcur = ggml_rope_multi( + ctx0, Kcur, inp_pos, nullptr, + n_rot, sections, rope_type, n_ctx_orig, freq_base, freq_scale, + ext_factor, attn_factor, beta_fast, beta_slow + ); + + cb(Qcur, "Qcur", il); + cb(Kcur, "Kcur", il); + cb(Vcur, "Vcur", il); + + cur = build_attn(inp_attn, + model.layers[il].wo, NULL, + Qcur, Kcur, Vcur, nullptr, nullptr, nullptr, 1.0f / sqrtf(float(n_embd_head)), il); + } + if (il == n_layer - 1) { + // skip computing output for unused tokens + cur = ggml_get_rows(ctx0, cur, inp_out_ids); + inpSA = ggml_get_rows(ctx0, inpSA, inp_out_ids); + } + ggml_tensor * ffn_inp = ggml_add(ctx0, cur, inpSA); + cb(ffn_inp, "ffn_inp", il); + + // feed-forward network + { + cur = build_norm(ffn_inp, model.layers[il].ffn_norm, NULL, LLM_NORM_RMS, il); + cb(cur, "ffn_norm", il); + + cur = build_ffn(cur, + model.layers[il].ffn_up, NULL, NULL, + model.layers[il].ffn_gate, NULL, NULL, + model.layers[il].ffn_down, NULL, NULL, + NULL, LLM_FFN_SILU, LLM_FFN_PAR, il); + cb(cur, "ffn_out", il); + } + cur = ggml_add(ctx0, cur, ffn_inp); + + cur = build_cvec(cur, il); + cb(cur, "l_out", il); + + // input for next layer + inpL = cur; + } + cur = inpL; + + cur = build_norm(cur, model.output_norm, NULL, LLM_NORM_RMS, -1); + + cb(cur, "result_norm", -1); + res->t_embd = cur; + + // lm_head + cur = build_lora_mm(model.output, cur); + + cb(cur, "result_output", -1); + res->t_logits = cur; + + ggml_build_forward_expand(gf, cur); +} diff --git a/tools/mtmd/clip-model.h b/tools/mtmd/clip-model.h index 8ef04b6b2b..f5c41ff138 100644 --- a/tools/mtmd/clip-model.h +++ b/tools/mtmd/clip-model.h @@ -39,7 +39,6 @@ struct clip_hparams { int32_t image_min_pixels = -1; int32_t image_max_pixels = -1; int32_t n_merge = 0; // number of patch merges **per-side** - int32_t proj_scale_factor = 0; float image_mean[3]; float image_std[3]; diff --git a/tools/mtmd/clip.cpp b/tools/mtmd/clip.cpp index cc022ad2e0..9142196639 100644 --- a/tools/mtmd/clip.cpp +++ b/tools/mtmd/clip.cpp @@ -1193,9 +1193,10 @@ struct clip_model_loader { } break; case PROJECTOR_TYPE_PADDLEOCR: { - hparams.proj_scale_factor = 2; - hparams.set_limit_image_tokens(8, 1024); - hparams.set_warmup_n_tokens(256); // avoid OOM on warmup + hparams.n_merge = 2; + // TODO(megemini): paddleocr vl not specified? + hparams.set_limit_image_tokens(8, 4096); + hparams.set_warmup_n_tokens(28*28); // avoid OOM on warmup } break; default: break; @@ -1460,7 +1461,7 @@ struct clip_model_loader { model.mm_model_ln_kv_w = get_tensor(string_format(TN_RESAMPL_LN, "kv", "weight")); model.mm_model_ln_kv_b = get_tensor(string_format(TN_RESAMPL_LN, "kv", "bias")); model.mm_model_ln_post_w = get_tensor(string_format(TN_RESAMPL_LN, "post", "weight")); - model.mm_model_ln_post_b = get_tensor(string_format(TN_RESAMPL_LN, "post", "bias")); + model.mm_model_ln_post_b = get_tensor(string_format(TN_RESAMPL_LN, "post", "bias")); } break; case PROJECTOR_TYPE_GLM_EDGE: { @@ -2869,6 +2870,7 @@ int clip_n_output_tokens_x(const struct clip_ctx * ctx, struct clip_image_f32 * case PROJECTOR_TYPE_QWEN25VL: case PROJECTOR_TYPE_QWEN3VL: case PROJECTOR_TYPE_GLM4V: + case PROJECTOR_TYPE_PADDLEOCR: return (img->nx / params.patch_size) / 2; default: break; @@ -2884,6 +2886,7 @@ int clip_n_output_tokens_y(const struct clip_ctx * ctx, struct clip_image_f32 * case PROJECTOR_TYPE_QWEN25VL: case PROJECTOR_TYPE_QWEN3VL: case PROJECTOR_TYPE_GLM4V: + case PROJECTOR_TYPE_PADDLEOCR: return (img->ny / params.patch_size) / 2; default: break; @@ -2971,8 +2974,8 @@ int clip_n_output_tokens(const struct clip_ctx * ctx, struct clip_image_f32 * im case PROJECTOR_TYPE_PADDLEOCR: { // dynamic size - int scale_factor = ctx->model.hparams.proj_scale_factor; - int stride = scale_factor * scale_factor; + int n_merge = ctx->model.hparams.n_merge; + int stride = n_merge * n_merge; n_patches = CLIP_ALIGN(n_patches, stride) / stride; } break; case PROJECTOR_TYPE_PIXTRAL: @@ -3219,6 +3222,29 @@ bool clip_image_batch_encode(clip_ctx * ctx, const int n_threads, const clip_ima } } + set_input_i32("positions", positions); + } break; + case PROJECTOR_TYPE_PADDLEOCR: + { + const int merge_ratio = hparams.n_merge; + const int pw = image_size_width / patch_size; + const int ph = image_size_height / patch_size; + std::vector positions(n_pos * 4); + int ptr = 0; + for (int dy = 0; dy < 2; dy++) { + for (int y = 0; y < ph; y += merge_ratio) { + for (int x = 0; x < pw; x += merge_ratio) { + for (int dx = 0; dx < 2; dx++) { + positions[ ptr] = y + dy; + positions[ num_patches + ptr] = x + dx; + positions[2 * num_patches + ptr] = y + dy; + positions[3 * num_patches + ptr] = x + dx; + ptr++; + } + } + } + } + set_input_i32("positions", positions); } break; case PROJECTOR_TYPE_QWEN25VL: @@ -3304,7 +3330,6 @@ bool clip_image_batch_encode(clip_ctx * ctx, const int n_threads, const clip_ima } break; case PROJECTOR_TYPE_PIXTRAL: case PROJECTOR_TYPE_KIMIVL: - case PROJECTOR_TYPE_PADDLEOCR: case PROJECTOR_TYPE_LIGHTONOCR: { // set the 2D positions @@ -3499,6 +3524,7 @@ bool clip_is_mrope(const struct clip_ctx * ctx) { return ctx->proj_type() == PROJECTOR_TYPE_QWEN2VL || ctx->proj_type() == PROJECTOR_TYPE_QWEN25VL || ctx->proj_type() == PROJECTOR_TYPE_QWEN3VL + || ctx->proj_type() == PROJECTOR_TYPE_PADDLEOCR || ctx->proj_type() == PROJECTOR_TYPE_GLM4V; } diff --git a/tools/mtmd/models/paddleocr.cpp b/tools/mtmd/models/paddleocr.cpp index ed8988ffef..92356f154b 100644 --- a/tools/mtmd/models/paddleocr.cpp +++ b/tools/mtmd/models/paddleocr.cpp @@ -1,23 +1,23 @@ #include "models.h" ggml_cgraph * clip_graph_paddleocr::build() { - // 2D input positions - ggml_tensor * pos_h = ggml_new_tensor_1d(ctx0, GGML_TYPE_I32, n_patches); - ggml_set_name(pos_h, "pos_h"); - ggml_set_input(pos_h); + const int n_pos = n_patches; + const int num_position_ids = n_pos * 4; // m-rope requires 4 dim per position - ggml_tensor * pos_w = ggml_new_tensor_1d(ctx0, GGML_TYPE_I32, n_patches); - ggml_set_name(pos_w, "pos_w"); - ggml_set_input(pos_w); + int mrope_sections[4] = {d_head/4, d_head/4, d_head/4, d_head/4}; - ggml_tensor * learned_pos_embd = resize_position_embeddings(); + ggml_tensor * positions = ggml_new_tensor_1d(ctx0, GGML_TYPE_I32, num_position_ids); + ggml_set_name(positions, "positions"); + ggml_set_input(positions); - // build ViT with 2D position embeddings auto add_pos = [&](ggml_tensor * cur, const clip_layer &) { - // first half is X axis and second half is Y axis - return build_rope_2d(ctx0, cur, pos_w, pos_h, hparams.rope_theta, false); + return ggml_rope_multi( + ctx0, cur, positions, nullptr, + d_head/2, mrope_sections, GGML_ROPE_TYPE_VISION, + 32768, 10000, 1, 0, 1, 32, 1); }; + ggml_tensor * learned_pos_embd = resize_position_embeddings(); ggml_tensor * inp = build_inp(); ggml_tensor * cur = build_vit( inp, n_patches, @@ -29,28 +29,16 @@ ggml_cgraph * clip_graph_paddleocr::build() { cb(cur, "vit_out", -1); { - // mlp_AR - float proj_norm_eps = 1e-5; // PaddleOCR uses hard-coded value eps=1e-5 for Projector + // mlp_AR paddleocr projector + float proj_norm_eps = 1e-5; cur = build_norm(cur, model.mm_input_norm_w, model.mm_input_norm_b, NORM_TYPE_NORMAL, proj_norm_eps, -1); - //cur = build_patch_merge_permute(cur, hparams.proj_scale_factor); - // stack and padding - int64_t stride = hparams.proj_scale_factor * hparams.proj_scale_factor; - int64_t n_embd = cur->ne[0]; - int64_t n_tokens = cur->ne[1]; - int64_t n_tokens_padded = CLIP_ALIGN(n_tokens, stride); - int64_t n_pad = n_tokens_padded - n_tokens; - if (n_pad > 0) { - cur = ggml_view_1d(ctx0, cur, ggml_nelements(cur), 0); - cur = ggml_pad(ctx0, cur, n_pad * n_embd, 0, 0, 0); - } - cur = ggml_view_2d(ctx0, cur, - n_embd * stride, - n_tokens_padded / stride, - ggml_row_size(cur->type, n_embd * stride), 0); - cb(cur, "after_stacked", -1); + const int scale_factor = model.hparams.n_merge; + int width = img.nx / patch_size; + int height = img.ny / patch_size; + cur = ggml_reshape_3d(ctx0, cur, n_embd * scale_factor * scale_factor, width / scale_factor * height / scale_factor, 1); cur = build_ffn(cur, model.mm_1_w, model.mm_1_b, From 0995fbbc93a7d261ca008883a2c26ccaef7467f0 Mon Sep 17 00:00:00 2001 From: megemini Date: Tue, 13 Jan 2026 13:40:11 +0800 Subject: [PATCH 04/10] [update] restore change of minicpmv --- tools/mtmd/clip-impl.h | 14 ++++++-------- tools/mtmd/clip.cpp | 40 ++++++++++++++++++++-------------------- 2 files changed, 26 insertions(+), 28 deletions(-) diff --git a/tools/mtmd/clip-impl.h b/tools/mtmd/clip-impl.h index bde7e3d999..a977fe5e9e 100644 --- a/tools/mtmd/clip-impl.h +++ b/tools/mtmd/clip-impl.h @@ -110,14 +110,12 @@ #define TN_DEEPSTACK_FC2 "v.deepstack.%d.fc2.%s" // qwen3vl deepstack // mimicpmv -#define TN_RESAMPL_POS_EMBD_K "resampler.pos_embed_k" -#define TN_RESAMPL_QUERY "resampler.query" -#define TN_RESAMPL_PROJ "resampler.proj.weight" -#define TN_RESAMPL_KV_PROJ "resampler.kv.weight" -#define TN_RESAMPL_ATTN "resampler.attn.%s.%s" -#define TN_RESAMPL_LN "resampler.ln_%s.%s" -#define TN_RESAMPL_FFN_UP "resampler.ffn_up.%s" -#define TN_RESAMPL_FFN_DOWN "resampler.ffn_down.%s" +#define TN_MINICPMV_POS_EMBD_K "resampler.pos_embed_k" +#define TN_MINICPMV_QUERY "resampler.query" +#define TN_MINICPMV_PROJ "resampler.proj.weight" +#define TN_MINICPMV_KV_PROJ "resampler.kv.weight" +#define TN_MINICPMV_ATTN "resampler.attn.%s.%s" +#define TN_MINICPMV_LN "resampler.ln_%s.%s" #define TN_GLM_ADAPER_CONV "adapter.conv.%s" #define TN_GLM_ADAPTER_LINEAR "adapter.linear.linear.%s" diff --git a/tools/mtmd/clip.cpp b/tools/mtmd/clip.cpp index 7d13b8a44d..3a32d819a3 100644 --- a/tools/mtmd/clip.cpp +++ b/tools/mtmd/clip.cpp @@ -1233,6 +1233,7 @@ struct clip_model_loader { // TODO(megemini): paddleocr vl not specified? hparams.set_limit_image_tokens(8, 4096); hparams.set_warmup_n_tokens(28*28); // avoid OOM on warmup + } break; case PROJECTOR_TYPE_LFM2A: { // audio preprocessing params @@ -1499,26 +1500,25 @@ struct clip_model_loader { } break; case PROJECTOR_TYPE_MINICPMV: { - // model.mm_model_pos_embed = get_tensor(new_clip->ctx_data, TN_RESAMPL_POS_EMBD); - model.mm_model_pos_embed_k = get_tensor(TN_RESAMPL_POS_EMBD_K); - model.mm_model_query = get_tensor(TN_RESAMPL_QUERY); - model.mm_model_proj = get_tensor(TN_RESAMPL_PROJ); - model.mm_model_kv_proj = get_tensor(TN_RESAMPL_KV_PROJ); - model.mm_model_attn_q_w = get_tensor(string_format(TN_RESAMPL_ATTN, "q", "weight")); - model.mm_model_attn_k_w = get_tensor(string_format(TN_RESAMPL_ATTN, "k", "weight")); - model.mm_model_attn_v_w = get_tensor(string_format(TN_RESAMPL_ATTN, "v", "weight")); - model.mm_model_attn_q_b = get_tensor(string_format(TN_RESAMPL_ATTN, "q", "bias")); - model.mm_model_attn_k_b = get_tensor(string_format(TN_RESAMPL_ATTN, "k", "bias")); - model.mm_model_attn_v_b = get_tensor(string_format(TN_RESAMPL_ATTN, "v", "bias")); - model.mm_model_attn_o_w = get_tensor(string_format(TN_RESAMPL_ATTN, "out", "weight")); - model.mm_model_attn_o_b = get_tensor(string_format(TN_RESAMPL_ATTN, "out", "bias")); - model.mm_model_ln_q_w = get_tensor(string_format(TN_RESAMPL_LN, "q", "weight")); - model.mm_model_ln_q_b = get_tensor(string_format(TN_RESAMPL_LN, "q", "bias")); - model.mm_model_ln_kv_w = get_tensor(string_format(TN_RESAMPL_LN, "kv", "weight")); - model.mm_model_ln_kv_b = get_tensor(string_format(TN_RESAMPL_LN, "kv", "bias")); - model.mm_model_ln_post_w = get_tensor(string_format(TN_RESAMPL_LN, "post", "weight")); - model.mm_model_ln_post_b = get_tensor(string_format(TN_RESAMPL_LN, "post", "bias")); - } break; + // model.mm_model_pos_embed = get_tensor(new_clip->ctx_data, TN_MINICPMV_POS_EMBD); + model.mm_model_pos_embed_k = get_tensor(TN_MINICPMV_POS_EMBD_K); + model.mm_model_query = get_tensor(TN_MINICPMV_QUERY); + model.mm_model_proj = get_tensor(TN_MINICPMV_PROJ); + model.mm_model_kv_proj = get_tensor(TN_MINICPMV_KV_PROJ); + model.mm_model_attn_q_w = get_tensor(string_format(TN_MINICPMV_ATTN, "q", "weight")); + model.mm_model_attn_k_w = get_tensor(string_format(TN_MINICPMV_ATTN, "k", "weight")); + model.mm_model_attn_v_w = get_tensor(string_format(TN_MINICPMV_ATTN, "v", "weight")); + model.mm_model_attn_q_b = get_tensor(string_format(TN_MINICPMV_ATTN, "q", "bias")); + model.mm_model_attn_k_b = get_tensor(string_format(TN_MINICPMV_ATTN, "k", "bias")); + model.mm_model_attn_v_b = get_tensor(string_format(TN_MINICPMV_ATTN, "v", "bias")); + model.mm_model_attn_o_w = get_tensor(string_format(TN_MINICPMV_ATTN, "out", "weight")); + model.mm_model_attn_o_b = get_tensor(string_format(TN_MINICPMV_ATTN, "out", "bias")); + model.mm_model_ln_q_w = get_tensor(string_format(TN_MINICPMV_LN, "q", "weight")); + model.mm_model_ln_q_b = get_tensor(string_format(TN_MINICPMV_LN, "q", "bias")); + model.mm_model_ln_kv_w = get_tensor(string_format(TN_MINICPMV_LN, "kv", "weight")); + model.mm_model_ln_kv_b = get_tensor(string_format(TN_MINICPMV_LN, "kv", "bias")); + model.mm_model_ln_post_w = get_tensor(string_format(TN_MINICPMV_LN, "post", "weight")); + model.mm_model_ln_post_b = get_tensor(string_format(TN_MINICPMV_LN, "post", "bias")); } break; case PROJECTOR_TYPE_GLM_EDGE: { model.mm_model_adapter_conv_w = get_tensor(string_format(TN_GLM_ADAPER_CONV, "weight")); From 73573b70f3d265b5ab1380c430d068a519cbca90 Mon Sep 17 00:00:00 2001 From: megemini Date: Tue, 13 Jan 2026 13:42:55 +0800 Subject: [PATCH 05/10] [update] format --- tools/mtmd/clip.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/mtmd/clip.cpp b/tools/mtmd/clip.cpp index 3a32d819a3..6b65d81bed 100644 --- a/tools/mtmd/clip.cpp +++ b/tools/mtmd/clip.cpp @@ -1518,7 +1518,8 @@ struct clip_model_loader { model.mm_model_ln_kv_w = get_tensor(string_format(TN_MINICPMV_LN, "kv", "weight")); model.mm_model_ln_kv_b = get_tensor(string_format(TN_MINICPMV_LN, "kv", "bias")); model.mm_model_ln_post_w = get_tensor(string_format(TN_MINICPMV_LN, "post", "weight")); - model.mm_model_ln_post_b = get_tensor(string_format(TN_MINICPMV_LN, "post", "bias")); } break; + model.mm_model_ln_post_b = get_tensor(string_format(TN_MINICPMV_LN, "post", "bias")); + } break; case PROJECTOR_TYPE_GLM_EDGE: { model.mm_model_adapter_conv_w = get_tensor(string_format(TN_GLM_ADAPER_CONV, "weight")); From 65e43e43f907837e1ccd9457e6083d8e13432707 Mon Sep 17 00:00:00 2001 From: megemini Date: Tue, 13 Jan 2026 13:44:16 +0800 Subject: [PATCH 06/10] [update] format --- tools/mtmd/clip.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/mtmd/clip.cpp b/tools/mtmd/clip.cpp index 6b65d81bed..96f7f5b1a3 100644 --- a/tools/mtmd/clip.cpp +++ b/tools/mtmd/clip.cpp @@ -1519,7 +1519,7 @@ struct clip_model_loader { model.mm_model_ln_kv_b = get_tensor(string_format(TN_MINICPMV_LN, "kv", "bias")); model.mm_model_ln_post_w = get_tensor(string_format(TN_MINICPMV_LN, "post", "weight")); model.mm_model_ln_post_b = get_tensor(string_format(TN_MINICPMV_LN, "post", "bias")); - } break; + } break; case PROJECTOR_TYPE_GLM_EDGE: { model.mm_model_adapter_conv_w = get_tensor(string_format(TN_GLM_ADAPER_CONV, "weight")); From d54c871ddd0e593e8e6c5157ea03d7adc58361ad Mon Sep 17 00:00:00 2001 From: megemini Date: Wed, 14 Jan 2026 13:39:04 +0800 Subject: [PATCH 07/10] [update] positions and patch merge permute --- tools/mtmd/clip.cpp | 4 ++-- tools/mtmd/models/paddleocr.cpp | 5 +---- 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/tools/mtmd/clip.cpp b/tools/mtmd/clip.cpp index 96f7f5b1a3..b163078a6c 100644 --- a/tools/mtmd/clip.cpp +++ b/tools/mtmd/clip.cpp @@ -3533,8 +3533,8 @@ bool clip_image_batch_encode(clip_ctx * ctx, const int n_threads, const clip_ima const int ph = image_size_height / patch_size; std::vector positions(n_pos * 4); int ptr = 0; - for (int dy = 0; dy < 2; dy++) { - for (int y = 0; y < ph; y += merge_ratio) { + for (int y = 0; y < ph; y += merge_ratio) { + for (int dy = 0; dy < 2; dy++) { for (int x = 0; x < pw; x += merge_ratio) { for (int dx = 0; dx < 2; dx++) { positions[ ptr] = y + dy; diff --git a/tools/mtmd/models/paddleocr.cpp b/tools/mtmd/models/paddleocr.cpp index 92356f154b..5d3a13fb57 100644 --- a/tools/mtmd/models/paddleocr.cpp +++ b/tools/mtmd/models/paddleocr.cpp @@ -36,10 +36,7 @@ ggml_cgraph * clip_graph_paddleocr::build() { NORM_TYPE_NORMAL, proj_norm_eps, -1); const int scale_factor = model.hparams.n_merge; - int width = img.nx / patch_size; - int height = img.ny / patch_size; - cur = ggml_reshape_3d(ctx0, cur, n_embd * scale_factor * scale_factor, width / scale_factor * height / scale_factor, 1); - + cur = build_patch_merge_permute(cur, scale_factor); cur = build_ffn(cur, model.mm_1_w, model.mm_1_b, nullptr, nullptr, From 9d5a701ebe06ac300049754167ec88c00bc78bd0 Mon Sep 17 00:00:00 2001 From: megemini Date: Wed, 14 Jan 2026 14:06:52 +0800 Subject: [PATCH 08/10] [update] mtmd_decode_use_mrope for paddleocr --- tools/mtmd/mtmd.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/mtmd/mtmd.cpp b/tools/mtmd/mtmd.cpp index 6610fc5df7..579afd5970 100644 --- a/tools/mtmd/mtmd.cpp +++ b/tools/mtmd/mtmd.cpp @@ -877,6 +877,7 @@ bool mtmd_decode_use_mrope(mtmd_context * ctx) { case PROJECTOR_TYPE_QWEN25VL: case PROJECTOR_TYPE_QWEN3VL: case PROJECTOR_TYPE_GLM4V: + case PROJECTOR_TYPE_PADDLEOCR: return true; default: return false; From 2f8c194135535f1e1bf0b324a97cdb1ececb9f25 Mon Sep 17 00:00:00 2001 From: megemini Date: Thu, 15 Jan 2026 13:33:30 +0800 Subject: [PATCH 09/10] [update] image min/max pixels --- gguf-py/gguf/constants.py | 4 ++-- gguf-py/gguf/gguf_writer.py | 6 +++--- tools/mtmd/clip-impl.h | 2 ++ tools/mtmd/clip.cpp | 3 +++ 4 files changed, 10 insertions(+), 5 deletions(-) diff --git a/gguf-py/gguf/constants.py b/gguf-py/gguf/constants.py index fd910cf996..26cc306184 100644 --- a/gguf-py/gguf/constants.py +++ b/gguf-py/gguf/constants.py @@ -284,8 +284,8 @@ class Keys: class ClipVision: PROJECTOR_TYPE = "clip.vision.projector_type" # for mixed modality models IMAGE_SIZE = "clip.vision.image_size" - MAX_PIXELS = "clip.vision.max_pixels" - MIN_PIXELS = "clip.vision.min_pixels" + IMAGE_MIN_PIXELS = "clip.vision.image_min_pixels" + IMAGE_MAX_PIXELS = "clip.vision.image_max_pixels" PREPROC_IMAGE_SIZE = "clip.vision.preproc_image_size" PATCH_SIZE = "clip.vision.patch_size" EMBEDDING_LENGTH = "clip.vision.embedding_length" diff --git a/gguf-py/gguf/gguf_writer.py b/gguf-py/gguf/gguf_writer.py index 76f0a9c3d2..39cb03191e 100644 --- a/gguf-py/gguf/gguf_writer.py +++ b/gguf-py/gguf/gguf_writer.py @@ -1099,11 +1099,11 @@ class GGUFWriter: self.add_uint32(Keys.ClipVision.EMBEDDING_LENGTH, value) def add_vision_max_pixels(self, value: int) -> None: - self.add_uint32(Keys.ClipVision.MAX_PIXELS, value) + self.add_uint32(Keys.ClipVision.IMAGE_MAX_PIXELS, value) def add_vision_min_pixels(self, value: int) -> None: - self.add_uint32(Keys.ClipVision.MIN_PIXELS, value) - + self.add_uint32(Keys.ClipVision.IMAGE_MIN_PIXELS, value) + def add_vision_feed_forward_length(self, value: int) -> None: self.add_uint32(Keys.ClipVision.FEED_FORWARD_LENGTH, value) diff --git a/tools/mtmd/clip-impl.h b/tools/mtmd/clip-impl.h index a977fe5e9e..5258ae841b 100644 --- a/tools/mtmd/clip-impl.h +++ b/tools/mtmd/clip-impl.h @@ -36,6 +36,8 @@ // vision-specific #define KEY_VISION_PROJ_TYPE "clip.vision.projector_type" // for models with mixed modalities #define KEY_IMAGE_SIZE "clip.vision.image_size" +#define KEY_IMAGE_MIN_PIXELS "clip.vision.image_min_pixels" +#define KEY_IMAGE_MAX_PIXELS "clip.vision.image_max_pixels" #define KEY_PREPROC_IMAGE_SIZE "clip.vision.preproc_image_size" #define KEY_PATCH_SIZE "clip.vision.patch_size" #define KEY_IMAGE_MEAN "clip.vision.image_mean" diff --git a/tools/mtmd/clip.cpp b/tools/mtmd/clip.cpp index 930b2061f1..a8b09a7827 100644 --- a/tools/mtmd/clip.cpp +++ b/tools/mtmd/clip.cpp @@ -1230,6 +1230,9 @@ struct clip_model_loader { case PROJECTOR_TYPE_PADDLEOCR: { hparams.n_merge = 2; + get_u32(KEY_IMAGE_MIN_PIXELS, hparams.image_min_pixels); + get_u32(KEY_IMAGE_MAX_PIXELS, hparams.image_max_pixels); + // TODO(megemini): paddleocr vl not specified? hparams.set_limit_image_tokens(8, 4096); hparams.set_warmup_n_tokens(28*28); // avoid OOM on warmup From 81de7fdbdee68b092ec2e374f4204a032c87094b Mon Sep 17 00:00:00 2001 From: megemini Date: Fri, 16 Jan 2026 18:53:42 +0800 Subject: [PATCH 10/10] [update] remove set_limit_image_tokens --- tools/mtmd/clip.cpp | 2 -- 1 file changed, 2 deletions(-) diff --git a/tools/mtmd/clip.cpp b/tools/mtmd/clip.cpp index f0d1a8dbac..d3d7a51044 100644 --- a/tools/mtmd/clip.cpp +++ b/tools/mtmd/clip.cpp @@ -1228,8 +1228,6 @@ struct clip_model_loader { get_u32(KEY_IMAGE_MIN_PIXELS, hparams.image_min_pixels); get_u32(KEY_IMAGE_MAX_PIXELS, hparams.image_max_pixels); - // TODO(megemini): paddleocr vl not specified? - hparams.set_limit_image_tokens(8, 4096); hparams.set_warmup_n_tokens(28*28); // avoid OOM on warmup } break; case PROJECTOR_TYPE_LFM2A: