UI: make more room for assistant message bubble's width
This commit is contained in:
parent
83abff8a64
commit
ad85bca98b
|
|
@ -32,19 +32,12 @@ import androidx.compose.foundation.shape.RoundedCornerShape
|
||||||
import androidx.compose.material.icons.Icons
|
import androidx.compose.material.icons.Icons
|
||||||
import androidx.compose.material.icons.automirrored.outlined.HelpOutline
|
import androidx.compose.material.icons.automirrored.outlined.HelpOutline
|
||||||
import androidx.compose.material.icons.filled.Timer
|
import androidx.compose.material.icons.filled.Timer
|
||||||
import androidx.compose.material3.AssistChip
|
|
||||||
import androidx.compose.material3.Button
|
|
||||||
import androidx.compose.material3.ButtonColors
|
|
||||||
import androidx.compose.material3.ButtonDefaults
|
|
||||||
import androidx.compose.material3.Card
|
import androidx.compose.material3.Card
|
||||||
import androidx.compose.material3.CardDefaults
|
import androidx.compose.material3.CardDefaults
|
||||||
import androidx.compose.material3.FilledTonalButton
|
|
||||||
import androidx.compose.material3.FilledTonalIconToggleButton
|
|
||||||
import androidx.compose.material3.FilterChip
|
import androidx.compose.material3.FilterChip
|
||||||
import androidx.compose.material3.HorizontalDivider
|
import androidx.compose.material3.HorizontalDivider
|
||||||
import androidx.compose.material3.Icon
|
import androidx.compose.material3.Icon
|
||||||
import androidx.compose.material3.IconButton
|
import androidx.compose.material3.IconButton
|
||||||
import androidx.compose.material3.IconButtonDefaults
|
|
||||||
import androidx.compose.material3.MaterialTheme
|
import androidx.compose.material3.MaterialTheme
|
||||||
import androidx.compose.material3.Text
|
import androidx.compose.material3.Text
|
||||||
import androidx.compose.runtime.Composable
|
import androidx.compose.runtime.Composable
|
||||||
|
|
@ -78,7 +71,6 @@ import com.example.llama.ui.components.ModelCardContentContextRow
|
||||||
import com.example.llama.ui.components.ModelCardContentField
|
import com.example.llama.ui.components.ModelCardContentField
|
||||||
import com.example.llama.ui.components.ModelCardCoreExpandable
|
import com.example.llama.ui.components.ModelCardCoreExpandable
|
||||||
import com.example.llama.ui.components.ModelUnloadDialogHandler
|
import com.example.llama.ui.components.ModelUnloadDialogHandler
|
||||||
import com.example.llama.ui.theme.ButtonShape
|
|
||||||
import com.example.llama.util.formatMilliSeconds
|
import com.example.llama.util.formatMilliSeconds
|
||||||
import com.example.llama.util.formatMilliSecondstructured
|
import com.example.llama.util.formatMilliSecondstructured
|
||||||
import com.example.llama.util.toEnglishName
|
import com.example.llama.util.toEnglishName
|
||||||
|
|
@ -319,6 +311,7 @@ private fun ConversationMessageList(
|
||||||
|
|
||||||
is Message.Assistant.Ongoing -> AssistantMessageBubble(
|
is Message.Assistant.Ongoing -> AssistantMessageBubble(
|
||||||
formattedTime = message.formattedTime,
|
formattedTime = message.formattedTime,
|
||||||
|
tokensCount = message.tokensCount,
|
||||||
content = message.content,
|
content = message.content,
|
||||||
isThinking = message.content.isBlank(),
|
isThinking = message.content.isBlank(),
|
||||||
isGenerating = true,
|
isGenerating = true,
|
||||||
|
|
@ -328,6 +321,7 @@ private fun ConversationMessageList(
|
||||||
|
|
||||||
is Message.Assistant.Stopped -> AssistantMessageBubble(
|
is Message.Assistant.Stopped -> AssistantMessageBubble(
|
||||||
formattedTime = message.formattedTime,
|
formattedTime = message.formattedTime,
|
||||||
|
tokensCount = message.metrics.tokensCount,
|
||||||
content = message.content,
|
content = message.content,
|
||||||
isThinking = false,
|
isThinking = false,
|
||||||
isGenerating = false,
|
isGenerating = false,
|
||||||
|
|
@ -385,83 +379,99 @@ private fun UserMessageBubble(content: String, formattedTime: String) {
|
||||||
@Composable
|
@Composable
|
||||||
private fun AssistantMessageBubble(
|
private fun AssistantMessageBubble(
|
||||||
formattedTime: String,
|
formattedTime: String,
|
||||||
|
tokensCount: Int,
|
||||||
content: String,
|
content: String,
|
||||||
isThinking: Boolean,
|
isThinking: Boolean,
|
||||||
isGenerating: Boolean,
|
isGenerating: Boolean,
|
||||||
metrics: TokenMetrics? = null,
|
metrics: TokenMetrics? = null,
|
||||||
onInfoClick: () -> Unit,
|
onInfoClick: () -> Unit,
|
||||||
) {
|
) {
|
||||||
Row(
|
val formattedTokensCount = when(tokensCount) {
|
||||||
modifier = Modifier.fillMaxWidth(),
|
0 -> ""
|
||||||
verticalAlignment = Alignment.Top,
|
1 -> "1 token"
|
||||||
|
else -> "$tokensCount tokens"
|
||||||
|
}
|
||||||
|
|
||||||
|
Column(
|
||||||
|
modifier = Modifier.fillMaxWidth(0.95f),
|
||||||
) {
|
) {
|
||||||
// Assistant avatar
|
// AI Assistant Avatar + Timestamp + Token count
|
||||||
Box(
|
Row(
|
||||||
modifier = Modifier
|
modifier = Modifier.fillMaxWidth().padding(bottom = 8.dp),
|
||||||
.size(36.dp)
|
verticalAlignment = Alignment.CenterVertically,
|
||||||
.clip(CircleShape)
|
|
||||||
.background(MaterialTheme.colorScheme.primary),
|
|
||||||
contentAlignment = Alignment.Center
|
|
||||||
) {
|
) {
|
||||||
Text(
|
Box(
|
||||||
text = "AI",
|
modifier = Modifier
|
||||||
color = MaterialTheme.colorScheme.onPrimary,
|
.size(36.dp)
|
||||||
style = MaterialTheme.typography.labelMedium
|
.clip(CircleShape)
|
||||||
)
|
.background(MaterialTheme.colorScheme.secondary),
|
||||||
}
|
contentAlignment = Alignment.Center
|
||||||
|
) {
|
||||||
|
Text(
|
||||||
|
text = "AI",
|
||||||
|
color = MaterialTheme.colorScheme.onSecondary,
|
||||||
|
style = MaterialTheme.typography.labelMedium
|
||||||
|
)
|
||||||
|
}
|
||||||
|
|
||||||
Spacer(modifier = Modifier.width(8.dp))
|
Column(
|
||||||
|
modifier = Modifier.padding(start = 12.dp),
|
||||||
Column(modifier = Modifier.fillMaxWidth(0.9f)) {
|
) {
|
||||||
// Timestamp above bubble
|
|
||||||
if (formattedTime.isNotBlank()) {
|
|
||||||
Text(
|
Text(
|
||||||
text = formattedTime,
|
text = formattedTime,
|
||||||
style = MaterialTheme.typography.labelSmall,
|
style = MaterialTheme.typography.labelSmall,
|
||||||
color = MaterialTheme.colorScheme.onSurfaceVariant.copy(alpha = 0.7f),
|
color = MaterialTheme.colorScheme.onSurfaceVariant.copy(alpha = 0.7f),
|
||||||
modifier = Modifier.padding(bottom = 4.dp)
|
modifier = Modifier.padding(bottom = 4.dp)
|
||||||
)
|
)
|
||||||
}
|
|
||||||
|
|
||||||
Card(
|
|
||||||
shape = RoundedCornerShape(2.dp, 16.dp, 16.dp, 16.dp),
|
|
||||||
colors = CardDefaults.cardColors(
|
|
||||||
containerColor = MaterialTheme.colorScheme.surfaceVariant
|
|
||||||
),
|
|
||||||
elevation = CardDefaults.cardElevation(defaultElevation = 1.dp)
|
|
||||||
) {
|
|
||||||
// Show actual content
|
|
||||||
Text(
|
Text(
|
||||||
modifier = Modifier.padding(12.dp),
|
text = formattedTokensCount,
|
||||||
text = content,
|
style = MaterialTheme.typography.labelSmall,
|
||||||
style = MaterialTheme.typography.bodyMedium,
|
color = MaterialTheme.colorScheme.onSurfaceVariant.copy(alpha = 0.7f),
|
||||||
color = MaterialTheme.colorScheme.onSurfaceVariant
|
|
||||||
)
|
)
|
||||||
}
|
}
|
||||||
|
|
||||||
// Show metrics or generation status below the bubble
|
}
|
||||||
if (isGenerating) {
|
|
||||||
Row(
|
|
||||||
modifier = Modifier.height(20.dp).padding(top = 4.dp),
|
|
||||||
verticalAlignment = Alignment.CenterVertically
|
|
||||||
) {
|
|
||||||
PulsatingDots(small = true)
|
|
||||||
|
|
||||||
Spacer(modifier = Modifier.width(4.dp))
|
Card(
|
||||||
|
shape = RoundedCornerShape(2.dp, 16.dp, 16.dp, 16.dp),
|
||||||
|
colors = CardDefaults.cardColors(
|
||||||
|
containerColor = MaterialTheme.colorScheme.secondaryContainer
|
||||||
|
),
|
||||||
|
elevation = CardDefaults.cardElevation(defaultElevation = 1.dp)
|
||||||
|
) {
|
||||||
|
// Show actual content
|
||||||
|
Text(
|
||||||
|
modifier = Modifier.padding(12.dp),
|
||||||
|
text = content,
|
||||||
|
style = MaterialTheme.typography.bodyMedium,
|
||||||
|
color = MaterialTheme.colorScheme.onSecondaryContainer
|
||||||
|
)
|
||||||
|
}
|
||||||
|
|
||||||
Text(
|
// Show metrics or generation status below the bubble
|
||||||
text = if (isThinking) "Thinking" else "",
|
if (isGenerating) {
|
||||||
style = MaterialTheme.typography.labelSmall,
|
Row(
|
||||||
color = MaterialTheme.colorScheme.primary
|
modifier = Modifier.height(20.dp).padding(top = 4.dp),
|
||||||
)
|
verticalAlignment = Alignment.CenterVertically
|
||||||
}
|
) {
|
||||||
} else {
|
PulsatingDots(small = true)
|
||||||
// Show metrics when message is complete
|
|
||||||
metrics?.let {
|
Spacer(modifier = Modifier.width(4.dp))
|
||||||
ExpandableTokenMetricsBubble(metrics, onInfoClick)
|
|
||||||
}
|
Text(
|
||||||
|
text = if (isThinking) "Thinking" else "",
|
||||||
|
style = MaterialTheme.typography.labelSmall,
|
||||||
|
color = MaterialTheme.colorScheme.primary
|
||||||
|
)
|
||||||
|
}
|
||||||
|
} else {
|
||||||
|
// Show metrics when message is complete
|
||||||
|
metrics?.let {
|
||||||
|
ExpandableTokenMetricsBubble(metrics, onInfoClick)
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
@ -512,7 +522,7 @@ private fun ExpandableTokenMetricsBubble(
|
||||||
) {
|
) {
|
||||||
var showMetrics by remember { mutableStateOf(false) }
|
var showMetrics by remember { mutableStateOf(false) }
|
||||||
|
|
||||||
Column(Modifier.fillMaxWidth(0.9f)) {
|
Column(Modifier.fillMaxWidth()) {
|
||||||
FilterChip(
|
FilterChip(
|
||||||
selected = showMetrics,
|
selected = showMetrics,
|
||||||
onClick = { showMetrics = !showMetrics },
|
onClick = { showMetrics = !showMetrics },
|
||||||
|
|
@ -536,13 +546,14 @@ private fun ExpandableTokenMetricsBubble(
|
||||||
Card(
|
Card(
|
||||||
shape = RoundedCornerShape(2.dp, 16.dp, 16.dp, 16.dp),
|
shape = RoundedCornerShape(2.dp, 16.dp, 16.dp, 16.dp),
|
||||||
colors = CardDefaults.cardColors(
|
colors = CardDefaults.cardColors(
|
||||||
containerColor = MaterialTheme.colorScheme.surfaceVariant
|
containerColor = MaterialTheme.colorScheme.secondaryContainer
|
||||||
),
|
),
|
||||||
elevation = CardDefaults.cardElevation(defaultElevation = 1.dp)
|
elevation = CardDefaults.cardElevation(defaultElevation = 1.dp)
|
||||||
) {
|
) {
|
||||||
Row(
|
Row(
|
||||||
modifier = Modifier.padding(12.dp),
|
modifier = Modifier.padding(12.dp),
|
||||||
horizontalArrangement = Arrangement.spacedBy(18.dp)
|
verticalAlignment = Alignment.CenterVertically,
|
||||||
|
horizontalArrangement = Arrangement.spacedBy(12.dp)
|
||||||
) {
|
) {
|
||||||
val ttft = formatMilliSecondstructured(metrics.ttftMs)
|
val ttft = formatMilliSecondstructured(metrics.ttftMs)
|
||||||
TokenMetricSection("1st Token", ttft.value.toString(), ttft.unit.toEnglishName())
|
TokenMetricSection("1st Token", ttft.value.toString(), ttft.unit.toEnglishName())
|
||||||
|
|
@ -557,7 +568,7 @@ private fun ExpandableTokenMetricsBubble(
|
||||||
Icon(
|
Icon(
|
||||||
modifier = Modifier.size(24.dp),
|
modifier = Modifier.size(24.dp),
|
||||||
imageVector = Icons.AutoMirrored.Outlined.HelpOutline,
|
imageVector = Icons.AutoMirrored.Outlined.HelpOutline,
|
||||||
tint = MaterialTheme.colorScheme.onSurfaceVariant,
|
tint = MaterialTheme.colorScheme.onSecondaryContainer,
|
||||||
contentDescription = "Information on token metrics"
|
contentDescription = "Information on token metrics"
|
||||||
)
|
)
|
||||||
}
|
}
|
||||||
|
|
|
||||||
Loading…
Reference in New Issue