From 9d895b0ed335492140a8ecc69b2be136376a0faf Mon Sep 17 00:00:00 2001 From: hanishkvc Date: Mon, 8 Dec 2025 16:28:27 +0530 Subject: [PATCH] SimpleSallap:SimpleMCP:Fix cmdline arg oversight, cleanup space Had forgotten to update docs wrt renamed --op.configFile arg Remove the unneeded space from details.md, which was triggering the editorconfig check at upstream github repo. --- tools/server/public_simplechat/docs/details.md | 4 ++-- tools/server/public_simplechat/local.tools/config.py | 2 +- tools/server/public_simplechat/readme.md | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/tools/server/public_simplechat/docs/details.md b/tools/server/public_simplechat/docs/details.md index 6ce83fce03..f63c6d53ba 100644 --- a/tools/server/public_simplechat/docs/details.md +++ b/tools/server/public_simplechat/docs/details.md @@ -95,7 +95,7 @@ remember to local.tools/simplemcp.py helper along with its config file, before using/loading this client ui through a browser - * cd tools/server/public_simplechat/local.tools; python3 ./simplemcp.py --config simplemcp.json + * cd tools/server/public_simplechat/local.tools; python3 ./simplemcp.py --op.configFile simplemcp.json * remember that this is a relatively minimal dumb mcp(ish) server logic with few builtin tool calls related to fetching raw html or stripped plain text equivalent or pdf text content. @@ -311,7 +311,7 @@ It is attached to the document object. Some of these can also be updated using t * setting this value to 0 (default), disables auto logic, so that end user can review the tool calls requested by ai and if needed even modify them, before triggering/executing them as well as review and modify results generated by the tool call, before submitting them back to the ai. * this is specified in seconds, so that users by default will normally not overload any website through the bundled mcp server. - + 1. the builtin tools' meta data is sent to the ai model in the requests sent to it. 2. inturn if the ai model requests a tool call to be made, the same will be done and the response sent back to the ai model, under user control, by default. diff --git a/tools/server/public_simplechat/local.tools/config.py b/tools/server/public_simplechat/local.tools/config.py index 448ec8bed5..370ebb9f52 100644 --- a/tools/server/public_simplechat/local.tools/config.py +++ b/tools/server/public_simplechat/local.tools/config.py @@ -152,7 +152,7 @@ class Config(DictyDataclassMixin): Helper to process command line arguments. Flow setup below such that - * location of --config in commandline will decide whether command line or config file will get + * location of --op.configFile in commandline will decide whether command line or config file will get priority wrt setting program parameters. * str type values in cmdline are picked up directly, without running them through ast.literal_eval, bcas otherwise one will have to ensure throught the cmdline arg mechanism that string quote is diff --git a/tools/server/public_simplechat/readme.md b/tools/server/public_simplechat/readme.md index 2526cfe8fc..a3987d698a 100644 --- a/tools/server/public_simplechat/readme.md +++ b/tools/server/public_simplechat/readme.md @@ -26,7 +26,7 @@ build/bin/llama-server -m \ If one needs web related access / tool calls dont forget to run ```bash -cd tools/server/public_simplechat/local.tools; python3 ./simplemcp.py --config simplemcp.json +cd tools/server/public_simplechat/local.tools; python3 ./simplemcp.py --op.configFile simplemcp.json ``` - `--debug True` enables debug mode which captures internet handshake data