happyz
/
llama.cpp
mirror of https://github.com/ggerganov/llama.cpp.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

removed error guard on dataset (its not generic)

This commit is contained in:
Salvatore Rossitto 2026-03-13 10:29:55 +01:00
parent d1f8d527ba
commit 99c2456bbb
1 changed files with 12 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
examples/qlora_training/finetune_qlora.cpp
View File

@ -217,11 +217,12 @@ static std::vector<training_sample> load_jsonl(
break;
}
}
if (last_assistant_content.find("Error:") != std::string::npos ||
last_assistant_content.find("error:") != std::string::npos) {
LOG_DBG("%s: skipping line %d — assistant response contains error marker\n", __func__, lineno);
continue;
}
// // this should be done on the python side...
// if (last_assistant_content.find("Error:") != std::string::npos ||
// last_assistant_content.find("error:") != std::string::npos) {
// LOG_DBG("%s: skipping line %d — assistant response contains error marker\n", __func__, lineno);
// continue;
// }
}
// Split into prompt (no loss) + last assistant response (loss).
@ -262,11 +263,12 @@ static std::vector<training_sample> load_jsonl(
}
} else if (j.contains("prompt") && j.contains("response")) {
response_text = j["response"].get<std::string>();
if (response_text.find("Error:") != std::string::npos ||
response_text.find("error:") != std::string::npos) {
LOG_DBG("%s: skipping line %d — response contains error marker\n", __func__, lineno);
continue;
}
// // this should be done on the python side...
// if (response_text.find("Error:") != std::string::npos ||
// response_text.find("error:") != std::string::npos) {
// LOG_DBG("%s: skipping line %d — response contains error marker\n", __func__, lineno);
// continue;
// }
prompt_text = j["prompt"].get<std::string>();
} else if (j.contains("text")) {
response_text = j["text"].get<std::string>();