happyz
/
llama.cpp
mirror of https://github.com/ggerganov/llama.cpp.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: address second round of review feedback 

- Remove unused #include <cstring>
- Fix false positive when only one backend is available
- Clarify comment: "reassign graph nodes" instead of "reassign ops"

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
Aristeidis Stathopoulos 2026-03-07 13:18:15 +02:00
parent 58faba86a9
commit 96d9f47a9c
2 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
include/llama.h
View File

@ -213,7 +213,7 @@ extern "C" {
typedef bool (*llama_progress_callback)(float progress, void * user_data);
// called after graph build but before memory allocation in llama_decode/llama_encode
// use ggml_backend_sched_set_tensor_backend() to reassign ops to a different backend
// use ggml_backend_sched_set_tensor_backend() to reassign graph nodes to a different backend
// NOTE: not called when a previous graph is reused; assignments from the last invocation
// persist. set LLAMA_GRAPH_REUSE_DISABLE=1 for per-decode control.
typedef void (*llama_pre_alloc_callback)(ggml_backend_sched_t sched, struct ggml_cgraph * gf, void * user_data);

10
tests/test-pre-alloc-callback.cpp
View File

@ -1,5 +1,4 @@
#include <cstdio>
#include <cstring>
#include "llama.h"
#include "get-model.h"
@ -31,8 +30,13 @@ static void pre_alloc_cb(ggml_backend_sched_t sched, struct ggml_cgraph * gf, vo
}
}
ggml_backend_sched_set_tensor_backend(sched, node, target);
state->reassign_ok = (ggml_backend_sched_get_tensor_backend(sched, node) == target);
if (target != current) {
ggml_backend_sched_set_tensor_backend(sched, node, target);
state->reassign_ok = (ggml_backend_sched_get_tensor_backend(sched, node) == target);
} else {
// only one backend available — can't test reassignment, just verify the callback was called
state->reassign_ok = true;
}
}
int main(int argc, char ** argv) {