From 72f80499ee18154da1830f4357f49d948fa28724 Mon Sep 17 00:00:00 2001 From: Georgi Gerganov Date: Mon, 24 Nov 2025 10:43:56 +0200 Subject: [PATCH] server : headers cleanup --- tools/server/server-common.cpp | 3 +++ tools/server/server-common.h | 13 ------------- tools/server/server-queue.cpp | 2 ++ tools/server/server-queue.h | 1 - tools/server/server.cpp | 17 ++++++++++++++--- 5 files changed, 19 insertions(+), 17 deletions(-) diff --git a/tools/server/server-common.cpp b/tools/server/server-common.cpp index 093d36fb09..18328f3afb 100644 --- a/tools/server/server-common.cpp +++ b/tools/server/server-common.cpp @@ -9,6 +9,9 @@ #include "server-common.h" +#include +#include + json format_error_response(const std::string & message, const enum error_type type) { std::string type_str; int code = 500; diff --git a/tools/server/server-common.h b/tools/server/server-common.h index df77ebc876..868c506103 100644 --- a/tools/server/server-common.h +++ b/tools/server/server-common.h @@ -5,27 +5,14 @@ #include "llama.h" #include "chat.h" #include "mtmd.h" -#include "mtmd-helper.h" #define JSON_ASSERT GGML_ASSERT #include -#include -#include #include #include -#include #include -// fix problem with std::min and std::max -#if defined(_WIN32) -#define WIN32_LEAN_AND_MEAN -#ifndef NOMINMAX -# define NOMINMAX -#endif -#include -#endif - #define DEFAULT_OAICOMPAT_MODEL "gpt-3.5-turbo" const static std::string build_info("b" + std::to_string(LLAMA_BUILD_NUMBER) + "-" + LLAMA_COMMIT); diff --git a/tools/server/server-queue.cpp b/tools/server/server-queue.cpp index afbf33ca59..5a74fd76ac 100644 --- a/tools/server/server-queue.cpp +++ b/tools/server/server-queue.cpp @@ -3,6 +3,8 @@ #include "log.h" +#include + #define QUE_INF(fmt, ...) LOG_INF("que %12.*s: " fmt, 12, __func__, __VA_ARGS__) #define QUE_WRN(fmt, ...) LOG_WRN("que %12.*s: " fmt, 12, __func__, __VA_ARGS__) #define QUE_ERR(fmt, ...) LOG_ERR("que %12.*s: " fmt, 12, __func__, __VA_ARGS__) diff --git a/tools/server/server-queue.h b/tools/server/server-queue.h index 529be817d2..47ef58425e 100644 --- a/tools/server/server-queue.h +++ b/tools/server/server-queue.h @@ -2,7 +2,6 @@ #include "server-task.h" -#include #include #include #include diff --git a/tools/server/server.cpp b/tools/server/server.cpp index 7d0cbc8091..0f39def379 100644 --- a/tools/server/server.cpp +++ b/tools/server/server.cpp @@ -10,6 +10,7 @@ #include "sampling.h" #include "speculative.h" #include "mtmd.h" +#include "mtmd-helper.h" #include #include @@ -19,6 +20,15 @@ #include #include +// fix problem with std::min and std::max +#if defined(_WIN32) +#define WIN32_LEAN_AND_MEAN +#ifndef NOMINMAX +# define NOMINMAX +#endif +#include +#endif + using json = nlohmann::ordered_json; constexpr int HTTP_POLLING_SECONDS = 1; @@ -3597,10 +3607,10 @@ private: } }; -std::function shutdown_handler; -std::atomic_flag is_terminating = ATOMIC_FLAG_INIT; +static std::function shutdown_handler; +static std::atomic_flag is_terminating = ATOMIC_FLAG_INIT; -inline void signal_handler(int signal) { +static inline void signal_handler(int signal) { if (is_terminating.test_and_set()) { // in case it hangs, we can force terminate the server by hitting Ctrl+C twice // this is for better developer experience, we can remove when the server is stable enough @@ -3769,6 +3779,7 @@ int main(int argc, char ** argv) { ctx_server.queue_tasks.terminate(); }; + // TODO: refactor in common/console #if defined (__unix__) || (defined (__APPLE__) && defined (__MACH__)) struct sigaction sigint_action; sigint_action.sa_handler = signal_handler;