happyz
/
llama.cpp
mirror of https://github.com/ggerganov/llama.cpp.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Stopped using static vector 

Using std::vector will cause g_col to be released before the logger thread exits, causing the logger thread to touch freed memory causing a crash
This commit is contained in:
Nakasaka, Masato 2026-04-24 17:23:08 +09:00
parent c827365ef4
commit 3d11a9b17f
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
common/log.cpp
View File

@ -49,7 +49,7 @@ enum common_log_col : int {
}; };
// disable colors by default // disable colors by default
static std::vector<const char *> g_col = { static const char* g_col[] = {
"", "",
"", "",
"", "",
@ -338,7 +338,7 @@ public:
g_col[COMMON_LOG_COL_CYAN] = LOG_COL_CYAN; g_col[COMMON_LOG_COL_CYAN] = LOG_COL_CYAN;
g_col[COMMON_LOG_COL_WHITE] = LOG_COL_WHITE; g_col[COMMON_LOG_COL_WHITE] = LOG_COL_WHITE;
} else { } else {
for (size_t i = 0; i < g_col.size(); i++) { for (size_t i = 0; i < std::size(g_col); i++) {
g_col[i] = ""; g_col[i] = "";
} }
} }