From 37f230dd7cff6732580bec976ca9e378af230d20 Mon Sep 17 00:00:00 2001 From: mtmcp <141645996+mtmcp@users.noreply.github.com> Date: Fri, 27 Mar 2026 05:25:58 -0300 Subject: [PATCH] =?UTF-8?q?completion=20:=20session=5Ftokens=20insert=20ra?= =?UTF-8?q?nge=20in=20completion=20tool=20(no-op=20=E2=86=92=20correct)=20?= =?UTF-8?q?(#20917)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The embd.begin(), embd.begin() range is empty and inserts nothing, so session_tokens never gets updated after decoding. Should be embd.begin(), embd.end(). Introduced in commit 2b6dfe8. --- tools/completion/completion.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/completion/completion.cpp b/tools/completion/completion.cpp index a24482956e..716a30fe9a 100644 --- a/tools/completion/completion.cpp +++ b/tools/completion/completion.cpp @@ -701,7 +701,7 @@ int main(int argc, char ** argv) { if (!common_prompt_batch_decode(ctx, embd, n_past, params.n_batch, path_session, save_now)) { return 1; } - session_tokens.insert(session_tokens.end(), embd.begin(), embd.begin()); + session_tokens.insert(session_tokens.end(), embd.begin(), embd.end()); n_session_consumed = session_tokens.size(); session_do_save = false;