happyz
/
llama.cpp
mirror of https://github.com/ggerganov/llama.cpp.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix agentic mcp image single model (#20339) 

* webui: fix MCP image attachments dropped during the agentic loop in single-model mode

* chore: update webui build output
This commit is contained in:
Pascal 2026-03-11 05:31:33 +01:00 committed by GitHub
parent e1a399992b
commit 00de615345
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

BIN
tools/server/public/index.html.gz
View File

Binary file not shown.

10
tools/server/webui/src/lib/stores/agentic.svelte.ts
View File

@ -318,6 +318,12 @@ class AgenticStore {
const maxTurns = agenticConfig.maxTurns; const maxTurns = agenticConfig.maxTurns;
const maxToolPreviewLines = agenticConfig.maxToolPreviewLines; const maxToolPreviewLines = agenticConfig.maxToolPreviewLines;
// Resolve effective model for vision capability checks.
// In ROUTER mode, options.model is always set by the caller.
// In MODEL mode, options.model is undefined; use the single loaded model
// which carries modalities bridged from /props.
const effectiveModel = options.model || modelsStore.models[0]?.model || '';
for (let turn = 0; turn < maxTurns; turn++) { for (let turn = 0; turn < maxTurns; turn++) {
this.updateSession(conversationId, { currentTurn: turn + 1 }); this.updateSession(conversationId, { currentTurn: turn + 1 });
agenticTimings.turns = turn + 1; agenticTimings.turns = turn + 1;
@ -571,14 +577,14 @@ class AgenticStore {
]; ];
for (const attachment of attachments) { for (const attachment of attachments) {
if (attachment.type === AttachmentType.IMAGE) { if (attachment.type === AttachmentType.IMAGE) {
if (modelsStore.modelSupportsVision(options.model ?? '')) { if (modelsStore.modelSupportsVision(effectiveModel)) {
contentParts.push({ contentParts.push({
type: ContentPartType.IMAGE_URL, type: ContentPartType.IMAGE_URL,
image_url: { url: (attachment as DatabaseMessageExtraImageFile).base64Url } image_url: { url: (attachment as DatabaseMessageExtraImageFile).base64Url }
}); });
} else { } else {
console.info( console.info(
`[AgenticStore] Skipping image attachment (model "${options.model}" does not support vision)` `[AgenticStore] Skipping image attachment (model "${effectiveModel}" does not support vision)`
); );
} }
} }