Commit Graph

851 Commits

Author SHA1 Message Date
RangerUFO 90b0e9fd7a Refactor the implementation of `Attention` 2024-03-21 14:40:56 +08:00
Jan Wassenberg a135bc1e47 Fix build for RPi, missing hn::. Refs #112, thanks long568
PiperOrigin-RevId: 617704418
2024-03-21 04:19:09 +01:00
Jan Wassenberg ba86c8d590 Remove obsolete copybara tags, faster bazel builds (debug)
PiperOrigin-RevId: 617576799
2024-03-21 04:19:02 +01:00
Jan Wassenberg f8baac80f9 Fix msan error, uninitialized model_training
This arose during the unpacking of LoaderArgs into individual ctor args. Probably better to pass LoaderArgs in, and have only a single ctor to reduce confusion.

Also fix includes.

PiperOrigin-RevId: 617386447
2024-03-21 04:18:55 +01:00
Eric Ye 52940d435f Connect "--weights" parameter to Gemma
PiperOrigin-RevId: 617323257
2024-03-21 04:18:48 +01:00
Eric Ye 89be4c3de8 No public description
PiperOrigin-RevId: 617315030
2024-03-21 04:18:36 +01:00
Jan Wassenberg 30b8a3c1ac Fix build for RPi, missing hn::. Refs #112, thanks long568
PiperOrigin-RevId: 617704418
2024-03-20 20:07:49 -07:00
Ville Sundell 546519c855
Added a missing space in app.h
When the user runs "--help", they see the non-existent word
"compressingnew". This is because of a missing space, which
is now added, resulting in "compressing new".
2024-03-21 00:39:45 +02:00
Jan Wassenberg 06cea2bcdb Remove obsolete copybara tags, faster bazel builds (debug)
PiperOrigin-RevId: 617576799
2024-03-20 23:37:39 +01:00
Jan Wassenberg edaafe335f Fix msan error, uninitialized model_training
This arose during the unpacking of LoaderArgs into individual ctor args. Probably better to pass LoaderArgs in, and have only a single ctor to reduce confusion.

Also fix includes.

PiperOrigin-RevId: 617386447
2024-03-20 23:37:32 +01:00
Eric Ye e2a04b79ed Connect "--weights" parameter to Gemma
PiperOrigin-RevId: 617323257
2024-03-20 23:37:25 +01:00
Eric Ye ffd02c59ad No public description
PiperOrigin-RevId: 617315030
2024-03-20 23:37:12 +01:00
Jan Wassenberg 7d5364bb80 Remove obsolete copybara tags, faster bazel builds (debug)
PiperOrigin-RevId: 617576799
2024-03-20 11:31:59 -07:00
RangerUFO 8fc6959950 Move conditional branch out of `pos2` loop 2024-03-20 23:50:14 +08:00
RangerUFO c75d2eb635 Add the missing `HWY_ATTR` of `ProjKV` 2024-03-20 23:21:43 +08:00
RangerUFO ce32f4db81 Streamline the implementation 2024-03-20 22:39:31 +08:00
Jan Wassenberg 11d9c51473 Fix msan error, uninitialized model_training
This arose during the unpacking of LoaderArgs into individual ctor args. Probably better to pass LoaderArgs in, and have only a single ctor to reduce confusion.

Also fix includes.

PiperOrigin-RevId: 617386447
2024-03-20 12:13:13 +01:00
Eric Ye 6865819bb7 Connect "--weights" parameter to Gemma
PiperOrigin-RevId: 617323257
2024-03-20 12:13:06 +01:00
Eric Ye fdc3812446 No public description
PiperOrigin-RevId: 617315030
2024-03-20 12:12:54 +01:00
RangerUFO 6923aec853 Add MQA support 2024-03-20 18:17:24 +08:00
RangerUFO 130e1f678f Adjust vocab size to be the same as gemma_pytorch 2024-03-20 18:17:24 +08:00
Jan Wassenberg 5e0cafbdc2 Fix msan error, uninitialized model_training
This arose during the unpacking of LoaderArgs into individual ctor args. Probably better to pass LoaderArgs in, and have only a single ctor to reduce confusion.

Also fix includes.

PiperOrigin-RevId: 617386447
2024-03-19 21:12:35 -07:00
Eric Ye fdb1091b9c Connect "--weights" parameter to Gemma
PiperOrigin-RevId: 617323257
2024-03-19 16:08:26 -07:00
enum-class 4400842337 Minor refactor in Softmax 2024-03-20 00:20:14 +08:00
enum-class 858d5b08c2 Use highway in AddFrom, MulBy, MulByConst, MulByConstAndAdd, create_distribution 2024-03-19 08:38:09 +08:00
Copybara-Service 720f609d84 Merge pull request #102 from google:experimental
PiperOrigin-RevId: 616882521
2024-03-18 10:56:52 -07:00
austinvhuang 810b5a0cc2 Update README with more details on contributing code, add experimental/ directory, add READMEs for subdirectories, clean up DEVELOPER notes 2024-03-15 14:10:24 -04:00
Copybara-Service 8fb44ed6dd Merge pull request #97 from ufownl:feature/topk_flag
PiperOrigin-RevId: 615772458
2024-03-14 07:34:55 -07:00
Copybara-Service a2ef389897 Merge pull request #98 from zeerd:patch-2
PiperOrigin-RevId: 615769065
2024-03-14 07:21:23 -07:00
Charles Chan 46c1aca304
Add missing log that point to a failed Generation 2024-03-14 10:03:25 +08:00
Eric Ye 1408784d7b Remove unused ascii banner string
PiperOrigin-RevId: 615504786
2024-03-13 12:21:46 -07:00
Copybara-Service a0f316d853 Merge pull request #95 from google:conversion
PiperOrigin-RevId: 615448039
2024-03-13 09:37:36 -07:00
pculliton f520e5c25c
Remove WIP messages. 2024-03-13 11:36:19 -04:00
RangerUFO 83ec42954f Allow changing k parameter of `SampleTopK` as a compiler flag 2024-03-13 13:55:37 +08:00
Jan Wassenberg 5fa2eb1a86 Use bf16-rounded sqrt for scaling embeddings to match Gemma
Thanks Daniel & Michael Han for pointing this out.
https://unsloth.ai/blog/gemma-bugs

PiperOrigin-RevId: 615250003
2024-03-12 19:15:13 -07:00
Copybara-Service 0221956b2e Merge pull request #87 from google:refactor-tidy
PiperOrigin-RevId: 615204427
2024-03-12 16:10:47 -07:00
Phil Culliton b6831a2256 Fixed 7B conversion. 2024-03-12 21:12:28 +00:00
austinvhuang 72247614bb fix prefill feedback off-by-1, update fetch commit hash 2024-03-12 15:10:44 -04:00
austinvhuang 4aa8d0584e Merge branch 'dev' into refactor-tidy 2024-03-12 15:01:46 -04:00
Austin Huang a9aa63fd2e Fix bazel build attempt #2 (remove //base through automation change).
https://github.com/google/gemma.cpp/actions/runs/8252325981/job/22571549312

PiperOrigin-RevId: 615097246
2024-03-12 10:43:26 -07:00
Austin Huang 9345b0aed5 Fix bazel build failure:
https://github.com/google/gemma.cpp/actions/runs/8252325981/job/22571549312

PiperOrigin-RevId: 615073081
2024-03-12 09:41:03 -07:00
Copybara-Service ccd055e06b Merge pull request #82 from google:examples
PiperOrigin-RevId: 615066980
2024-03-12 09:24:24 -07:00
Jan Wassenberg 0d406061c0 Detect and print build type. Refs #88
PiperOrigin-RevId: 614906000
2024-03-11 21:58:10 -07:00
Copybara-Service a9be065c28 Merge pull request #77 from enum-class:rmsnorm
PiperOrigin-RevId: 614642173
2024-03-11 06:25:57 -07:00
enum-class 6712f07ee7 Merge branch 'dev' into rmsnorm 2024-03-11 20:13:18 +08:00
Saman 683c1b5c32
Merge branch 'google:main' into rmsnorm 2024-03-11 20:01:16 +08:00
austinvhuang 60d054e041 move arg definitions out of gemma.h to app.h 2024-03-10 23:49:25 -04:00
Copybara-Service e577198fc0 Merge pull request #78 from enum-class:rmsnorm2
PiperOrigin-RevId: 614480854
2024-03-10 16:14:44 -07:00
austinvhuang 415464b047 fix CMakeLists typo 2024-03-10 15:41:17 -04:00
austinvhuang 5d323c00fe fix tokenizer scope 2024-03-10 13:23:16 -04:00