fix: update header include paths in C++ files

This commit is contained in:
Olamiposi Otesile 2026-01-13 23:33:02 +01:00
parent 4c56598b74
commit c3c1ed7f00
17 changed files with 75 additions and 63 deletions

View File

@ -29,19 +29,20 @@
#include "compression/compress.h" // ScaleWeights #include "compression/compress.h" // ScaleWeights
#include "gemma/configs.h" // ModelConfig #include "gemma/configs.h" // ModelConfig
#include "gemma/io/blob_store.h" // BlobWriter
#include "gemma/io/io.h" // Path
#include "gemma/model_store.h" // ModelStore #include "gemma/model_store.h" // ModelStore
#include "gemma/tensor_info.h" // TensorInfo #include "gemma/tensor_info.h" // TensorInfo
#include "gemma/tokenizer.h" #include "gemma/tokenizer.h"
#include "io/blob_store.h" // BlobWriter
#include "io/io.h" // Path
#include "util/basics.h" #include "util/basics.h"
#include "util/mat.h" #include "util/mat.h"
#include "util/threading_context.h" #include "util/threading_context.h"
#undef HWY_TARGET_INCLUDE #undef HWY_TARGET_INCLUDE
#define HWY_TARGET_INCLUDE \ #define HWY_TARGET_INCLUDE \
"compression/python/compression_clif_aux.cc" // NOLINT "compression/python/compression_clif_aux.cc" // NOLINT
#include "hwy/foreach_target.h" // IWYU pragma: keep #include "hwy/foreach_target.h" // IWYU pragma: keep
#include "hwy/highway.h" #include "hwy/highway.h"
// After highway.h // After highway.h
#include "compression/compress-inl.h" #include "compression/compress-inl.h"

View File

@ -23,11 +23,12 @@
#include "compression/types.h" // Type #include "compression/types.h" // Type
#include "gemma/configs.h" #include "gemma/configs.h"
#include "gemma/io/blob_store.h"
#include "gemma/model_store.h" #include "gemma/model_store.h"
#include "gemma/tensor_info.h" #include "gemma/tensor_info.h"
#include "io/blob_store.h"
#include "util/mat.h"
#include "hwy/aligned_allocator.h" // Span #include "hwy/aligned_allocator.h" // Span
#include "util/mat.h"
namespace gcpp { namespace gcpp {

View File

@ -11,11 +11,12 @@
#include "evals/benchmark_helper.h" #include "evals/benchmark_helper.h"
#include "evals/cross_entropy.h" #include "evals/cross_entropy.h"
#include "gemma/gemma.h" #include "gemma/gemma.h"
#include "io/io.h" // Path #include "gemma/io/io.h" // Path
#include "util/args.h"
#include "hwy/base.h" #include "hwy/base.h"
#include "hwy/timer.h" #include "hwy/timer.h"
#include "nlohmann/json.hpp" #include "nlohmann/json.hpp"
#include "util/args.h"
namespace gcpp { namespace gcpp {
@ -85,8 +86,8 @@ int BenchmarkCrossEntropy(GemmaEnv& env, const Path& text,
LogSpeedStats(time_start, pos + num_tokens); LogSpeedStats(time_start, pos + num_tokens);
std::string text_slice = env.StringFromTokens(prompt_slice); std::string text_slice = env.StringFromTokens(prompt_slice);
total_input_len += text_slice.size(); total_input_len += text_slice.size();
printf("Total cross entropy: %f [cumulative: %f]\n", printf("Total cross entropy: %f [cumulative: %f]\n", entropy,
entropy, total_entropy); total_entropy);
printf("Cross entropy per byte: %f [cumulative: %f]\n", printf("Cross entropy per byte: %f [cumulative: %f]\n",
entropy / text_slice.size(), total_entropy / total_input_len); entropy / text_slice.size(), total_entropy / total_input_len);
} }

View File

@ -20,10 +20,11 @@
#include "evals/benchmark_helper.h" #include "evals/benchmark_helper.h"
#include "gemma/gemma.h" // LayersOutputFunc #include "gemma/gemma.h" // LayersOutputFunc
#include "io/io.h" #include "gemma/io/io.h"
#include "util/args.h"
#include "hwy/base.h" #include "hwy/base.h"
#include "nlohmann/json.hpp" #include "nlohmann/json.hpp"
#include "util/args.h"
using json = nlohmann::json; using json = nlohmann::json;

View File

@ -21,12 +21,13 @@
#include "evals/benchmark_helper.h" #include "evals/benchmark_helper.h"
#include "gemma/gemma.h" // Gemma #include "gemma/gemma.h" // Gemma
#include "io/io.h" // Path #include "gemma/io/io.h" // Path
#include "util/args.h"
#include "hwy/base.h" #include "hwy/base.h"
#include "hwy/highway.h" #include "hwy/highway.h"
#include "hwy/profiler.h" #include "hwy/profiler.h"
#include "nlohmann/json.hpp" #include "nlohmann/json.hpp"
#include "util/args.h"
namespace gcpp { namespace gcpp {

View File

@ -21,14 +21,15 @@
#include <string> #include <string>
#include <vector> #include <vector>
#include "io/blob_store.h" #include "gemma/io/blob_store.h"
#include "io/io.h" // Path #include "gemma/io/io.h" // Path
#include "util/basics.h" // IndexRange
#include "util/threading.h"
#include "util/threading_context.h"
#include "hwy/aligned_allocator.h" // Span #include "hwy/aligned_allocator.h" // Span
#include "hwy/base.h" #include "hwy/base.h"
#include "hwy/timer.h" #include "hwy/timer.h"
#include "util/basics.h" // IndexRange
#include "util/threading.h"
#include "util/threading_context.h"
namespace gcpp { namespace gcpp {
@ -106,8 +107,8 @@ void ReadBlobs(BlobReader& reader, const RangeVec& ranges, BlobVec& blobs,
ThreadingContext& ctx, size_t cluster_idx) { ThreadingContext& ctx, size_t cluster_idx) {
HWY_ASSERT(reader.Keys().size() == blobs.size()); HWY_ASSERT(reader.Keys().size() == blobs.size());
HWY_ASSERT(ranges.size() == blobs.size()); HWY_ASSERT(ranges.size() == blobs.size());
ParallelFor(Parallelism::kWithinCluster, blobs.size(), ctx, ParallelFor(Parallelism::kWithinCluster, blobs.size(), ctx, cluster_idx,
cluster_idx, Callers::kTest, [&](size_t i, size_t /*thread*/) { Callers::kTest, [&](size_t i, size_t /*thread*/) {
HWY_ASSERT(ranges[i].bytes == blobs[i].size()); HWY_ASSERT(ranges[i].bytes == blobs[i].size());
reader.file().Read(ranges[i].offset, ranges[i].bytes, reader.file().Read(ranges[i].offset, ranges[i].bytes,
blobs[i].data()); blobs[i].data());
@ -189,8 +190,8 @@ void CompareBlobs(const KeyVec& keys, BlobVec& blobs1, BlobVec& blobs2,
const double t0 = hwy::platform::Now(); const double t0 = hwy::platform::Now();
std::atomic<size_t> blobs_equal{}; std::atomic<size_t> blobs_equal{};
std::atomic<size_t> blobs_diff{}; std::atomic<size_t> blobs_diff{};
ParallelFor(Parallelism::kHierarchical, keys.size(), ctx, 0, ParallelFor(Parallelism::kHierarchical, keys.size(), ctx, 0, Callers::kTest,
Callers::kTest, [&](size_t i, size_t /*thread*/) { [&](size_t i, size_t /*thread*/) {
const size_t mismatches = const size_t mismatches =
BlobDifferences(blobs1[i], blobs2[i], keys[i]); BlobDifferences(blobs1[i], blobs2[i], keys[i]);
if (mismatches != 0) { if (mismatches != 0) {

View File

@ -13,7 +13,7 @@
// See the License for the specific language governing permissions and // See the License for the specific language governing permissions and
// limitations under the License. // limitations under the License.
#include "io/blob_store.h" #include "gemma/io/blob_store.h"
#include <stddef.h> #include <stddef.h>
#include <stdint.h> #include <stdint.h>
@ -24,12 +24,13 @@
#include <utility> // std::move #include <utility> // std::move
#include <vector> #include <vector>
#include "io/io.h" #include "gemma/io/io.h"
#include "util/threading_context.h"
#include "hwy/aligned_allocator.h" // Span #include "hwy/aligned_allocator.h" // Span
#include "hwy/base.h" #include "hwy/base.h"
#include "hwy/detect_compiler_arch.h" #include "hwy/detect_compiler_arch.h"
#include "hwy/profiler.h" #include "hwy/profiler.h"
#include "util/threading_context.h"
namespace gcpp { namespace gcpp {
@ -490,25 +491,24 @@ void BlobWriter::Add(const std::string& key, const void* data, size_t bytes) {
const Parallelism parallelism = const Parallelism parallelism =
file_->IsAppendOnly() ? Parallelism::kNone : Parallelism::kFlat; file_->IsAppendOnly() ? Parallelism::kNone : Parallelism::kFlat;
ParallelFor( ParallelFor(parallelism, writes.size(), ctx_,
parallelism, writes.size(), ctx_, /*cluster_idx=*/0, Callers::kBlobWriter,
/*cluster_idx=*/0, Callers::kBlobWriter, [this, &writes](uint64_t i, size_t /*thread*/) {
[this, &writes](uint64_t i, size_t /*thread*/) { const BlobRange& range = writes[i].range;
const BlobRange& range = writes[i].range; if (!file_->Write(writes[i].data, range.bytes, range.offset)) {
if (!file_->Write(writes[i].data, range.bytes, range.offset)) { const std::string& key = StringFromKey(keys_[range.key_idx]);
const std::string& key = StringFromKey(keys_[range.key_idx]); HWY_ABORT("Write failed for %s from %zu, %zu bytes to %p.",
HWY_ABORT("Write failed for %s from %zu, %zu bytes to %p.", key.c_str(), static_cast<size_t>(range.offset),
key.c_str(), static_cast<size_t>(range.offset), range.bytes, range.bytes, writes[i].data);
writes[i].data); }
} });
});
curr_offset_ = writes.back().range.End(); curr_offset_ = writes.back().range.End();
} }
void BlobWriter::Finalize() { void BlobWriter::Finalize() {
if (!file_->IsAppendOnly() && curr_offset_ != file_->FileSize()) { if (!file_->IsAppendOnly() && curr_offset_ != file_->FileSize()) {
HWY_WARN("Computed offset %zu does not match file size %zu.", HWY_WARN("Computed offset %zu does not match file size %zu.", curr_offset_,
curr_offset_, file_->FileSize()); file_->FileSize());
} }
const BlobStore bs = BlobStore(keys_, blob_sizes_); const BlobStore bs = BlobStore(keys_, blob_sizes_);

View File

@ -26,11 +26,12 @@
#include <unordered_map> #include <unordered_map>
#include <vector> #include <vector>
#include "io/io.h" // File, Path, MapPtr #include "gemma/io/io.h" // File, Path, MapPtr
#include "util/basics.h" // Tristate
#include "util/threading_context.h"
#include "hwy/aligned_allocator.h" // Span #include "hwy/aligned_allocator.h" // Span
#include "hwy/base.h" // HWY_ASSERT #include "hwy/base.h" // HWY_ASSERT
#include "util/basics.h" // Tristate
#include "util/threading_context.h"
namespace gcpp { namespace gcpp {

View File

@ -13,7 +13,7 @@
// See the License for the specific language governing permissions and // See the License for the specific language governing permissions and
// limitations under the License. // limitations under the License.
#include "io/blob_store.h" #include "gemma/io/blob_store.h"
#include <stdio.h> #include <stdio.h>
@ -22,11 +22,12 @@
#include <string> #include <string>
#include <vector> #include <vector>
#include "io/io.h" #include "gemma/io/io.h"
#include "util/basics.h"
#include "util/threading_context.h"
#include "hwy/tests/hwy_gtest.h" #include "hwy/tests/hwy_gtest.h"
#include "hwy/tests/test_util-inl.h" // HWY_ASSERT_EQ #include "hwy/tests/test_util-inl.h" // HWY_ASSERT_EQ
#include "util/basics.h"
#include "util/threading_context.h"
namespace gcpp { namespace gcpp {
namespace { namespace {
@ -130,8 +131,8 @@ TEST(BlobStoreTest, TestNumBlobs) {
HWY_ASSERT_EQ(reader.Keys().size(), num_blobs); HWY_ASSERT_EQ(reader.Keys().size(), num_blobs);
ParallelFor( ParallelFor(
Parallelism::kFlat, num_blobs, ctx, /*cluster_idx=*/0, Parallelism::kFlat, num_blobs, ctx, /*cluster_idx=*/0, Callers::kTest,
Callers::kTest, [&](uint64_t i, size_t /*thread*/) { [&](uint64_t i, size_t /*thread*/) {
HWY_ASSERT_STRING_EQ(reader.Keys()[i].c_str(), HWY_ASSERT_STRING_EQ(reader.Keys()[i].c_str(),
std::to_string(i).c_str()); std::to_string(i).c_str());
const BlobRange* range = reader.Find(keys[i]); const BlobRange* range = reader.Find(keys[i]);

View File

@ -13,8 +13,7 @@
// See the License for the specific language governing permissions and // See the License for the specific language governing permissions and
// limitations under the License. // limitations under the License.
#include "io/fields.h" #include "gemma/io/fields.h"
#include <stdarg.h> #include <stdarg.h>
#include <stddef.h> #include <stddef.h>
#include <stdint.h> #include <stdint.h>

View File

@ -13,7 +13,7 @@
// See the License for the specific language governing permissions and // See the License for the specific language governing permissions and
// limitations under the License. // limitations under the License.
#include "io/fields.h" #include "gemma/io/fields.h"
#include <stddef.h> #include <stddef.h>
#include <stdint.h> #include <stdint.h>
@ -21,11 +21,12 @@
#include <limits> #include <limits>
#include <string> #include <string>
#include <vector>
#include <type_traits> #include <type_traits>
#include <vector>
#include "hwy/tests/hwy_gtest.h" #include "hwy/tests/hwy_gtest.h"
namespace gcpp { namespace gcpp {
namespace { namespace {

View File

@ -31,7 +31,7 @@
#include <memory> #include <memory>
#include <string> #include <string>
#include "io/io.h" #include "gemma/io/io.h"
#include "hwy/base.h" // HWY_ASSERT #include "hwy/base.h" // HWY_ASSERT
#if (HWY_OS_LINUX || HWY_OS_FREEBSD) && \ #if (HWY_OS_LINUX || HWY_OS_FREEBSD) && \

View File

@ -21,9 +21,10 @@
#include <stddef.h> #include <stddef.h>
#include <stdint.h> #include <stdint.h>
#include "io/io.h" #include "gemma/io/io.h"
#include "util/allocator.h"
#include "hwy/base.h" // HWY_ASSERT #include "hwy/base.h" // HWY_ASSERT
#include "util/allocator.h"
#ifndef WIN32_LEAN_AND_MEAN #ifndef WIN32_LEAN_AND_MEAN
#define WIN32_LEAN_AND_MEAN #define WIN32_LEAN_AND_MEAN
#endif #endif

View File

@ -30,7 +30,7 @@
#include <utility> #include <utility>
#include <vector> #include <vector>
#include "io/io.h" #include "gemma/io/io.h"
#include "hwy/aligned_allocator.h" // hwy::Span #include "hwy/aligned_allocator.h" // hwy::Span
#include "hwy/base.h" #include "hwy/base.h"
#include "hwy/profiler.h" #include "hwy/profiler.h"

View File

@ -24,9 +24,10 @@
#include <string> #include <string>
#include <vector> #include <vector>
#include "io/io.h" // Path #include "gemma/io/io.h" // Path
#include "hwy/base.h" // HWY_ABORT
#include "util/basics.h" // Tristate #include "util/basics.h" // Tristate
#include "hwy/base.h" // HWY_ABORT
namespace gcpp { namespace gcpp {

View File

@ -24,10 +24,11 @@
// IWYU pragma: begin_exports // IWYU pragma: begin_exports
#include "compression/types.h" // Type #include "compression/types.h" // Type
#include "gemma/io/fields.h"
#include "gemma/tensor_info.h" #include "gemma/tensor_info.h"
#include "io/fields.h"
#include "util/allocator.h" // AlignedPtr #include "util/allocator.h" // AlignedPtr
#include "util/basics.h" // Extents2D #include "util/basics.h" // Extents2D
// IWYU pragma: end_exports // IWYU pragma: end_exports
#include "hwy/base.h" #include "hwy/base.h"
@ -457,7 +458,7 @@ decltype(auto) CallUpcastedActivation(const MatPtr* base, const Func& func,
// Like CallUpcasted, but only for kv_cache types: kBF16 and kF32. // Like CallUpcasted, but only for kv_cache types: kBF16 and kF32.
template <class Func, typename... Args> template <class Func, typename... Args>
decltype(auto) CallUpcastedKV(const MatPtr* base, const Func& func, decltype(auto) CallUpcastedKV(const MatPtr* base, const Func& func,
Args&&... args) { Args&&... args) {
if (base->GetType() == Type::kF32) { if (base->GetType() == Type::kF32) {
const MatPtrT<float> mat(*base); const MatPtrT<float> mat(*base);
return func(&mat, std::forward<Args>(args)...); return func(&mat, std::forward<Args>(args)...);

View File

@ -23,14 +23,15 @@
#include <stdint.h> #include <stdint.h>
// IWYU pragma: begin_exports // IWYU pragma: begin_exports
#include "io/io.h" // Path #include "gemma/io/io.h" // Path
#include "hwy/profiler.h"
#include "util/allocator.h" #include "util/allocator.h"
#include "util/args.h" #include "util/args.h"
#include "util/basics.h" // Tristate #include "util/basics.h" // Tristate
#include "util/threading.h" #include "util/threading.h"
#include "util/topology.h" #include "util/topology.h"
#include "util/zones.h" #include "util/zones.h"
#include "hwy/profiler.h"
// IWYU pragma: end_exports // IWYU pragma: end_exports
namespace gcpp { namespace gcpp {