happyz
/
gemma.cpp
mirror of https://github.com/google/gemma.cpp.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Update AssertClose for large matrices and add large matrix test 

PiperOrigin-RevId: 642277221
This commit is contained in:
Phil Culliton 2024-06-11 08:22:12 -07:00 committed by Copybara-Service
parent 8ec8eef524
commit b6565e3bf6
1 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
gemma/ops_test.cc
View File

@ -510,11 +510,14 @@ template <typename MatT>
void AssertClose(const MatT* HWY_RESTRICT expected, void AssertClose(const MatT* HWY_RESTRICT expected,
const MatT* HWY_RESTRICT actual, size_t num) { const MatT* HWY_RESTRICT actual, size_t num) {
for (size_t idx = 0; idx < num; idx++) { for (size_t idx = 0; idx < num; idx++) {
double expected_value = hwy::ConvertScalarTo<double>(expected[idx]); const double expected_value = hwy::ConvertScalarTo<double>(expected[idx]);
double actual_value = hwy::ConvertScalarTo<double>(actual[idx]); const double actual_value = hwy::ConvertScalarTo<double>(actual[idx]);
const double magnitude = std::abs(expected_value);
const double tolerance = const double tolerance =
expected_value * 21 * 1.0 / (1ULL << hwy::MantissaBits<MatT>()); 64.0 * hwy::ConvertScalarTo<double>(hwy::Epsilon<MatT>()) *
HWY_MAX(magnitude, 1.0);
if (!(expected_value - tolerance <= actual_value && if (!(expected_value - tolerance <= actual_value &&
actual_value <= expected_value + tolerance)) { actual_value <= expected_value + tolerance)) {
@ -559,7 +562,7 @@ void TestAllTiledMatMul() {
// large-scale test // large-scale test
// TODO(philculliton): investigate rounding issues with large matrices // TODO(philculliton): investigate rounding issues with large matrices
// TestTiledMatMul<512, 24576, 3072, float>(); TestTiledMatMul<512, 24576, 3072, float>();
// TODO(janwas): SFP // TODO(janwas): SFP
} }