mirror of https://github.com/google/gemma.cpp.git
Fix copybara include path substitutions errors (which break the google3 build) arising from clang-format linter automation
This commit is contained in:
parent
f70d2de16f
commit
8f3bd63bf7
|
|
@ -1,6 +1,5 @@
|
|||
---
|
||||
Language: Cpp
|
||||
# BasedOnStyle: Google
|
||||
AccessModifierOffset: -1
|
||||
AlignAfterOpenBracket: Align
|
||||
AlignArrayOfStructures: None
|
||||
|
|
@ -211,7 +210,7 @@ RequiresClausePosition: OwnLine
|
|||
RequiresExpressionIndentation: OuterScope
|
||||
SeparateDefinitionBlocks: Leave
|
||||
ShortNamespaceLines: 1
|
||||
SortIncludes: CaseSensitive
|
||||
SortIncludes: Never
|
||||
SortJavaStaticImport: Before
|
||||
SortUsingDeclarations: LexicographicNumeric
|
||||
SpaceAfterCStyleCast: false
|
||||
|
|
|
|||
|
|
@ -83,6 +83,14 @@ A `.clang-format` configuration is provided with our defaults, please run source
|
|||
files through `clang-format` (or a formatter that produces equivalent behavior)
|
||||
before finalizing PR for submission.
|
||||
|
||||
The `.clang-format` is the google style (as of feb 27 2024), except with
|
||||
`SortIncludes` set to `false` to avoid breaking copybara path substitutions
|
||||
which rely on adjacent comments.
|
||||
|
||||
For transparency, `.clang-format` can be reproduced using the
|
||||
`make_clang_format_config.sh` script in `utils/` run with `clang-format` version
|
||||
17.0.6.
|
||||
|
||||
## Compile-Time Flags (Advanced)
|
||||
|
||||
There are several compile-time flags to be aware of (note these may or may not
|
||||
|
|
|
|||
2
gemma.h
2
gemma.h
|
|
@ -29,10 +29,10 @@
|
|||
// copybara:import_next_line:gemma_cpp
|
||||
#include "configs.h" // kSeqLen
|
||||
// copybara:import_next_line:gemma_cpp
|
||||
#include "util/args.h" // ArgsBase
|
||||
#include "hwy/aligned_allocator.h"
|
||||
#include "hwy/base.h" // hwy::bfloat16_t
|
||||
#include "hwy/contrib/thread_pool/thread_pool.h"
|
||||
#include "util/args.h" // ArgsBase
|
||||
// copybara:import_next_line:sentencepiece
|
||||
#include "src/sentencepiece_processor.h"
|
||||
|
||||
|
|
|
|||
|
|
@ -0,0 +1,4 @@
|
|||
#!/bin/bash
|
||||
|
||||
# Reproduces .clang-format file.
|
||||
clang-format -style="{BasedOnStyle: Google, SortIncludes: false}" -dump-config > .clang-format
|
||||
Loading…
Reference in New Issue