From 673673cc985cdbf63f83c8ccec2f51c586eac3dd Mon Sep 17 00:00:00 2001
From: Daniel Keysers <keysers@google.com>
Date: Tue, 24 Sep 2024 02:12:20 -0700
Subject: [PATCH] Update expected entropy values for GRIFFIN_2B model. These
 changed after introduction of "Cascaded summation for Softmax"

PiperOrigin-RevId: 678145851
---
 evals/gemma_test.cc | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/evals/gemma_test.cc b/evals/gemma_test.cc
index d70788c..6f36b7a 100644
--- a/evals/gemma_test.cc
+++ b/evals/gemma_test.cc
@@ -247,7 +247,7 @@ TEST_F(GemmaTest, CrossEntropySmall) {
       EXPECT_NEAR(entropy, 2.8f, 0.2f);
       break;
     case gcpp::Model::GRIFFIN_2B:
-      EXPECT_NEAR(entropy, 2.25f, 0.02f);
+      EXPECT_NEAR(entropy, 1.57f, 0.02f);
       break;
     case gcpp::Model::GEMMA2_2B:
       EXPECT_NEAR(entropy, 1.14f, 0.02f);
@@ -278,7 +278,7 @@ TEST_F(GemmaTest, CrossEntropyJingleBells) {
       EXPECT_NEAR(entropy, 1.07f, 0.05f);
       break;
     case gcpp::Model::GRIFFIN_2B:
-      EXPECT_NEAR(entropy, 1.95f, 0.02f);
+      EXPECT_NEAR(entropy, 2.09f, 0.02f);
       break;
     case gcpp::Model::GEMMA2_2B:
       EXPECT_NEAR(entropy, 0.49f, 0.02f);
@@ -309,7 +309,7 @@ TEST_F(GemmaTest, CrossEntropyGettysburg) {
       EXPECT_NEAR(entropy, 0.75f, 0.1f);
       break;
     case gcpp::Model::GRIFFIN_2B:
-      EXPECT_NEAR(entropy, 0.82f, 0.02f);
+      EXPECT_NEAR(entropy, 0.86f, 0.02f);
       break;
     case gcpp::Model::GEMMA2_2B:
       EXPECT_NEAR(entropy, 0.20f, 0.02f);