From 3af439621e360b54c6cad660c54928a40a92d68c Mon Sep 17 00:00:00 2001 From: Dan Zheng Date: Sat, 24 Feb 2024 14:52:59 -0800 Subject: [PATCH] Rename BUILD to BUILD.bazel. (#36) * Rename BUILD to BUILD.bazel. This fixes an error on macOS due to `build` and `BUILD` having conflicting names. * Enable macos-latest in GitHub Actions CI. * Fix concurrency key in GitHub Actions. Use matrix configuration in concurrency key. --- .github/workflows/build.yml | 8 +++--- BUILD.bazel | 51 ------------------------------------- 2 files changed, 4 insertions(+), 55 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 929e140..b0d4b6e 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -1,11 +1,11 @@ -name: Build +name: build # Trigger on push or via manual dispatch. on: [push, workflow_dispatch] jobs: build: - runs-on: ${{matrix.os}} + runs-on: ${{ matrix.os }} name: ${{ matrix.os }} ${{ matrix.type }} timeout-minutes: 30 @@ -13,10 +13,10 @@ jobs: fail-fast: false matrix: type: ['Release'] - os: ['ubuntu-latest'] + os: ['ubuntu-latest', 'macos-latest'] concurrency: - group: ${{ github.workflow }}-${{ github.ref }} + group: ${{ github.workflow }}-${{ github.ref }}-${{ matrix.os }}-${{ matrix.type }} cancel-in-progress: true steps: diff --git a/BUILD.bazel b/BUILD.bazel index 190690b..18dad30 100644 --- a/BUILD.bazel +++ b/BUILD.bazel @@ -114,54 +114,3 @@ cc_binary( "//:thread_pool", ], ) - -# copybara:strip_begin -cc_binary( - name = "run_csv", - srcs = [ - "run_csv.cc", - ], - deps = [ - ":app", - ":args", - ":gemma_lib", - "//compression:compress", - # copybara:import_next_line:hwy - "//:hwy", - # copybara:import_next_line:hwy - "//:nanobenchmark", - # copybara:import_next_line:hwy - "//:profiler", - # copybara:import_next_line:hwy - "//:thread_pool", - "//third_party/riegeli/bytes:file_reader", - "//third_party/riegeli/bytes:file_writer", - "//third_party/riegeli/csv:csv_reader", - "//third_party/riegeli/csv:csv_writer", - ], -) - -gensignature( - name = "gemma_sign", - srcs = [":gemma"], -) - -cc_test( - name = "benchmarks", - size = "large", - srcs = [ - "benchmarks.cc", - ], - tags = ["notap"], - deps = [ - ":app", - ":gemma_lib", - "//third_party/benchmark", - # copybara:import_next_line:hwy - "//:hwy", - # copybara:import_next_line:hwy - "//:thread_pool", - ], -) - -# copybara:strip_end