From 2290eb7d3fd2acf3622eb893447843ad6da4d782 Mon Sep 17 00:00:00 2001 From: Daniel Keysers Date: Thu, 26 Sep 2024 01:53:48 -0700 Subject: [PATCH] Reduce flakiness of dot_test. PiperOrigin-RevId: 679049273 --- ops/dot_test.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ops/dot_test.cc b/ops/dot_test.cc index 24e2edb..1c6265c 100644 --- a/ops/dot_test.cc +++ b/ops/dot_test.cc @@ -775,7 +775,7 @@ class DotStats { // Forward relative error, lower is better. void CheckRel() const { - ASSERT_INSIDE(kComp2, 2E-4, s_rels[kComp2].GeometricMean(), 3.5E-3); + ASSERT_INSIDE(kComp2, 2E-4, s_rels[kComp2].GeometricMean(), 3.7E-3); ASSERT_INSIDE(kComp2, 1E-5f, s_rels[kComp2].Max(), 0.4f); // Compensated is very accurate. @@ -785,7 +785,7 @@ class DotStats { // Naive and OnlyTwoProd are considerably higher, but not huge. ASSERT_INSIDE(kNaive, 1E-3, s_rels[kNaive].GeometricMean(), 8E-2); ASSERT_INSIDE(kOnlyTwoProd, 1E-3, s_rels[kOnlyTwoProd].GeometricMean(), - 0.06); + 0.065); // Kahan (FastTwoSum) is decent: ASSERT_INSIDE(kKahan, 3E-4, s_rels[kKahan].GeometricMean(), 3.5E-3);