happyz
/
gemma.cpp
mirror of https://github.com/google/gemma.cpp.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Update expected ranges in dot_test. 

PiperOrigin-RevId: 684515143
This commit is contained in:
Daniel Keysers 2024-10-10 11:28:38 -07:00 committed by Copybara-Service
parent 6ab3ff5bde
commit 1eb9ce19dd
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
ops/dot_test.cc
View File

@ -813,7 +813,7 @@ class DotStats {
// Forward relative error, lower is better. // Forward relative error, lower is better.
void CheckRel() const { void CheckRel() const {
ASSERT_INSIDE(kComp2, 2E-4, s_rels[kComp2].GeometricMean(), 3.7E-3); ASSERT_INSIDE(kComp2, 2E-4, s_rels[kComp2].GeometricMean(), 3.8E-3);
ASSERT_INSIDE(kComp2, 1E-5f, s_rels[kComp2].Max(), 1.23f); ASSERT_INSIDE(kComp2, 1E-5f, s_rels[kComp2].Max(), 1.23f);
// Compensated and Double are very accurate. // Compensated and Double are very accurate.
@ -825,7 +825,7 @@ class DotStats {
// Naive and OnlyTwoProd are considerably higher, but not huge. // Naive and OnlyTwoProd are considerably higher, but not huge.
ASSERT_INSIDE(kNaive, 1E-3, s_rels[kNaive].GeometricMean(), 8E-2); ASSERT_INSIDE(kNaive, 1E-3, s_rels[kNaive].GeometricMean(), 8E-2);
ASSERT_INSIDE(kOnlyTwoProd, 1E-3, s_rels[kOnlyTwoProd].GeometricMean(), ASSERT_INSIDE(kOnlyTwoProd, 1E-3, s_rels[kOnlyTwoProd].GeometricMean(),
0.065); 0.072);
// Kahan (FastTwoSum) is decent: // Kahan (FastTwoSum) is decent:
ASSERT_INSIDE(kKahan, 3E-4, s_rels[kKahan].GeometricMean(), 3.5E-3); ASSERT_INSIDE(kKahan, 3E-4, s_rels[kKahan].GeometricMean(), 3.5E-3);
@ -845,7 +845,7 @@ class DotStats {
// Backward relative error, lower is better. // Backward relative error, lower is better.
void CheckBwd() const { void CheckBwd() const {
ASSERT_INSIDE(kComp2, 7E-10f, s_rels[kComp2].Max(), 0.4f); ASSERT_INSIDE(kComp2, 7E-10f, s_rels[kComp2].Max(), 1.3f);
// Compensated and Double are very accurate. // Compensated and Double are very accurate.
ASSERT_LESS(kCompensated, s_rels[kCompensated].Max(), 8E-6f); ASSERT_LESS(kCompensated, s_rels[kCompensated].Max(), 8E-6f);