happyz
/
fastapi
mirror of https://github.com/tiangolo/fastapi.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

feat: add check in websocket routes and support prefix for Starlette Routers

This commit is contained in:
Irfanuddin 2022-11-12 01:00:26 +05:30
parent 20661e1301
commit d11ed8208b
No known key found for this signature in database
GPG Key ID: EDDB7CBA28F0477C
2 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
fastapi/dependencies/utils.py
View File

@ -757,5 +757,6 @@ def get_body_field(*, dependant: Dependant, name: str) -> Optional[ModelField]:
return final_field
def get_path_hash_val(path: str, methods: Optional[Set[str]]) -> str:
def get_path_hash_val(path: str, methods: Optional[Set[str]] = None) -> str:
methods = methods or {"GET"}
return f"path:{path};methods:{methods}"

6
fastapi/routing.py
View File

@ -677,6 +677,10 @@ class APIRouter(routing.Router):
name=name,
dependency_overrides_provider=self.dependency_overrides_provider,
)
hash_val = get_path_hash_val(route.path)
if hash_val in self.added_routes:
raise RouteAlreadyExistsError(route.name)
self.added_routes.add(hash_val)
self.routes.append(route)
def websocket(
@ -781,7 +785,7 @@ class APIRouter(routing.Router):
)
elif isinstance(route, routing.Route):
methods = list(route.methods or [])
hash_val = get_path_hash_val(route.path, route.methods)
hash_val = get_path_hash_val(prefix + route.path, route.methods)
if hash_val in self.added_routes:
raise RouteAlreadyExistsError(route.name)
self.added_routes.add(hash_val)