This commit is contained in:
Alexander Rauhut 2026-03-16 10:21:04 +00:00 committed by GitHub
commit 4faeef920d
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 78 additions and 1 deletions

View File

@ -840,10 +840,11 @@ class APIRoute(routing.Route):
generate_unique_id_function: Callable[["APIRoute"], str]
| DefaultPlaceholder = Default(generate_unique_id),
strict_content_type: bool | DefaultPlaceholder = Default(True),
stream_item_type: Any | None = None,
) -> None:
self.path = path
self.endpoint = endpoint
self.stream_item_type: Any | None = None
self.stream_item_type: Any | None = stream_item_type
if isinstance(response_model, DefaultPlaceholder):
return_annotation = get_typed_return_annotation(endpoint)
if lenient_issubclass(return_annotation, Response):
@ -1364,6 +1365,7 @@ class APIRouter(routing.Router):
generate_unique_id_function: Callable[[APIRoute], str]
| DefaultPlaceholder = Default(generate_unique_id),
strict_content_type: bool | DefaultPlaceholder = Default(True),
stream_item_type: Any | None = None,
) -> None:
route_class = route_class_override or self.route_class
responses = responses or {}
@ -1413,6 +1415,7 @@ class APIRouter(routing.Router):
strict_content_type=get_value_or_default(
strict_content_type, self.strict_content_type
),
stream_item_type=stream_item_type,
)
self.routes.append(route)
@ -1793,6 +1796,7 @@ class APIRouter(routing.Router):
router.strict_content_type,
self.strict_content_type,
),
stream_item_type=route.stream_item_type,
)
elif isinstance(route, routing.Route):
methods = list(route.methods or [])

View File

@ -96,6 +96,18 @@ async def stream_events():
yield {"msg": "world"}
@router.get("/events-typed", response_class=EventSourceResponse)
async def stream_events_typed() -> AsyncIterable[Item]:
for item in items:
yield item
@router.get("/events-jsonl")
async def stream_events_jsonl() -> AsyncIterable[Item]:
for item in items:
yield item
app.include_router(router, prefix="/api")
@ -265,6 +277,67 @@ def test_sse_on_router_included_in_app(client: TestClient):
assert len(data_lines) == 2
def test_sse_router_typed_stream(client: TestClient):
response = client.get("/api/events-typed")
assert response.status_code == 200
assert response.headers["content-type"] == "text/event-stream; charset=utf-8"
data_lines = [
line for line in response.text.strip().split("\n") if line.startswith("data: ")
]
assert len(data_lines) == 3
def test_jsonl_router_typed_stream(client: TestClient):
response = client.get("/api/events-jsonl")
assert response.status_code == 200
assert response.headers["content-type"] == "application/jsonl"
lines = response.text.strip().split("\n")
assert len(lines) == 3
def test_sse_router_typed_openapi_schema(client: TestClient):
"""Typed SSE endpoint on a router should preserve itemSchema with contentSchema."""
response = client.get("/openapi.json")
assert response.status_code == 200
paths = response.json()["paths"]
sse_response = paths["/api/events-typed"]["get"]["responses"]["200"]
assert sse_response == {
"description": "Successful Response",
"content": {
"text/event-stream": {
"itemSchema": {
"type": "object",
"properties": {
"data": {
"type": "string",
"contentMediaType": "application/json",
"contentSchema": {"$ref": "#/components/schemas/Item"},
},
"event": {"type": "string"},
"id": {"type": "string"},
"retry": {"type": "integer", "minimum": 0},
},
"required": ["data"],
}
}
},
}
def test_jsonl_router_typed_openapi_schema(client: TestClient):
"""Typed JSONL endpoint on a router should preserve itemSchema."""
response = client.get("/openapi.json")
assert response.status_code == 200
paths = response.json()["paths"]
jsonl_response = paths["/api/events-jsonl"]["get"]["responses"]["200"]
assert jsonl_response == {
"description": "Successful Response",
"content": {
"application/jsonl": {"itemSchema": {"$ref": "#/components/schemas/Item"}}
},
}
# Keepalive ping tests