happyz
/
fastapi
mirror of https://github.com/tiangolo/fastapi.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix `on_startup` and `on_shutdown` parameters of `APIRouter`

This commit is contained in:
Yurii Motov 2026-02-09 09:16:20 +01:00
parent cd31576d57
commit 4561d575b7
1 changed files with 11 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
fastapi/routing.py
View File

@ -952,16 +952,6 @@ class APIRouter(routing.Router):
), ),
] = Default(generate_unique_id), ] = Default(generate_unique_id),
) -> None: ) -> None:
# Handle on_startup/on_shutdown locally since Starlette removed support
# Ref: https://github.com/Kludex/starlette/pull/3117
# TODO: deprecate this once the lifespan (or alternative) interface is improved
self.on_startup: list[Callable[[], Any]] = (
[] if on_startup is None else list(on_startup)
)
self.on_shutdown: list[Callable[[], Any]] = (
[] if on_shutdown is None else list(on_shutdown)
)
# Determine the lifespan context to use # Determine the lifespan context to use
if lifespan is None: if lifespan is None:
# Use the default lifespan that runs on_startup/on_shutdown handlers # Use the default lifespan that runs on_startup/on_shutdown handlers
@ -985,6 +975,17 @@ class APIRouter(routing.Router):
assert not prefix.endswith("/"), ( assert not prefix.endswith("/"), (
"A path prefix must not end with '/', as the routes will start with '/'" "A path prefix must not end with '/', as the routes will start with '/'"
) )
# Handle on_startup/on_shutdown locally since Starlette removed support
# Ref: https://github.com/Kludex/starlette/pull/3117
# TODO: deprecate this once the lifespan (or alternative) interface is improved
self.on_startup: list[Callable[[], Any]] = (
[] if on_startup is None else list(on_startup)
)
self.on_shutdown: list[Callable[[], Any]] = (
[] if on_shutdown is None else list(on_shutdown)
)
self.prefix = prefix self.prefix = prefix
self.tags: list[Union[str, Enum]] = tags or [] self.tags: list[Union[str, Enum]] = tags or []
self.dependencies = list(dependencies or []) self.dependencies = list(dependencies or [])