happyz
/
fastapi
mirror of https://github.com/tiangolo/fastapi.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

📝 Fix inconsistent response code when item already exists in docs for testing (#11818) 

Co-authored-by: Sebastián Ramírez <tiangolo@gmail.com>
This commit is contained in:
Luke Okomilo 2024-08-15 23:31:16 +01:00 committed by GitHub
parent 366bdebd9e
commit 2cb1333b97
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
6 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
docs_src/app_testing/app_b_an/main.py
View File

@ -34,6 +34,6 @@ async def create_item(item: Item, x_token: Annotated[str, Header()]):
if x_token != fake_secret_token: if x_token != fake_secret_token:
raise HTTPException(status_code=400, detail="Invalid X-Token header") raise HTTPException(status_code=400, detail="Invalid X-Token header")
if item.id in fake_db: if item.id in fake_db:
raise HTTPException(status_code=400, detail="Item already exists") raise HTTPException(status_code=409, detail="Item already exists")
fake_db[item.id] = item fake_db[item.id] = item
return item return item

2
docs_src/app_testing/app_b_an/test_main.py
View File

@ -61,5 +61,5 @@ def test_create_existing_item():
"description": "There goes my stealer", "description": "There goes my stealer",
}, },
) )
assert response.status_code == 400 assert response.status_code == 409
assert response.json() == {"detail": "Item already exists"} assert response.json() == {"detail": "Item already exists"}

2
docs_src/app_testing/app_b_an_py310/main.py
View File

@ -33,6 +33,6 @@ async def create_item(item: Item, x_token: Annotated[str, Header()]):
if x_token != fake_secret_token: if x_token != fake_secret_token:
raise HTTPException(status_code=400, detail="Invalid X-Token header") raise HTTPException(status_code=400, detail="Invalid X-Token header")
if item.id in fake_db: if item.id in fake_db:
raise HTTPException(status_code=400, detail="Item already exists") raise HTTPException(status_code=409, detail="Item already exists")
fake_db[item.id] = item fake_db[item.id] = item
return item return item

2
docs_src/app_testing/app_b_an_py310/test_main.py
View File

@ -61,5 +61,5 @@ def test_create_existing_item():
"description": "There goes my stealer", "description": "There goes my stealer",
}, },
) )
assert response.status_code == 400 assert response.status_code == 409
assert response.json() == {"detail": "Item already exists"} assert response.json() == {"detail": "Item already exists"}

2
docs_src/app_testing/app_b_an_py39/main.py
View File

@ -33,6 +33,6 @@ async def create_item(item: Item, x_token: Annotated[str, Header()]):
if x_token != fake_secret_token: if x_token != fake_secret_token:
raise HTTPException(status_code=400, detail="Invalid X-Token header") raise HTTPException(status_code=400, detail="Invalid X-Token header")
if item.id in fake_db: if item.id in fake_db:
raise HTTPException(status_code=400, detail="Item already exists") raise HTTPException(status_code=409, detail="Item already exists")
fake_db[item.id] = item fake_db[item.id] = item
return item return item

2
docs_src/app_testing/app_b_an_py39/test_main.py
View File

@ -61,5 +61,5 @@ def test_create_existing_item():
"description": "There goes my stealer", "description": "There goes my stealer",
}, },
) )
assert response.status_code == 400 assert response.status_code == 409
assert response.json() == {"detail": "Item already exists"} assert response.json() == {"detail": "Item already exists"}